Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add a constructor overload for CallbackScope #39768

Closed
wants to merge 2 commits into from
Closed

src: add a constructor overload for CallbackScope #39768

wants to merge 2 commits into from

Commits on Aug 15, 2021

  1. src: add a constructor overload for CallbackScope 

    This overload accepts the current Environment* as an argument, unlike
the other constructor, which accepts an Isolate*. This is useful because
we can pass the current Environment* directly instead of recomputing it
from the Isolate* inside the constructor.

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    @RaisinTen
    RaisinTen committed Aug 15, 2021
    Copy the full SHA
    85073c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. src: call overload ctor from the original ctor 

    Call the new constructor overload from the original constructor to
reduce code duplication.

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    @RaisinTen
    RaisinTen committed Aug 17, 2021
    Copy the full SHA
    795069a View commit details
    Browse the repository at this point in the history