Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 00bb1a77c03e #39829

Closed
wants to merge 1 commit into from

Commits on Aug 21, 2021

  1. deps: V8: cherry-pick 00bb1a77c03e

    Original commit message:
    
        [date] Fix Date#getMinutes() test failures
    
        After building V8 using Clang (./out/x64.release/v8_build_config.json
        says that "is_clang" is true), I could reproduce the referenced bug
        report locally. Replacing the getMinutes() calls with getUTCMinutes()
        calls fixed the test failure.
    
        Signed-off-by: Darshan Sen <raisinten@gmail.com>
        Bug: v8:11200
        Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Commit-Queue: Toon Verwaest <verwaest@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#76367}
    
    Refs: v8/v8@00bb1a7
    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    RaisinTen committed Aug 21, 2021
    Copy the full SHA
    7fa085f View commit details
    Browse the repository at this point in the history