New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,url: correct URL's argument to pass idlharness #39848

Closed

XadillaX wants to merge 1 commit into nodejs:master from XadillaX:url-idlharness

Commits on Aug 24, 2021

lib,url: correct URL's argument to pass idlharness

`url.idl` defines URL's constructor as:

```
constructor(USVString url, optional USVString base);
```

`idlharness.any.js` checks its length as `1`. So we should remove
constructor's second argument and use `arguments[1]` in constructor's
logic.

Refs: https://url.spec.whatwg.org/#idl-index

XadillaX committed Aug 24, 2021