build: update actions file #39871
build: update actions file #39871
Conversation
nodejs-github-bot
added
the
meta
| - main | ||
| - v[0-9]+.x-staging | ||
| - v[0-9]+.x | ||
| branches: [master, main, 'v[0-9]+.x-staging', 'v[0-9]+.x'] |
There was a problem hiding this comment.
I find multiline arrays easier to read (and also to review when elements are added/removed)
There was a problem hiding this comment.
The line just above is (and was) a single line areay, and the two lines have almost the same size. Personally I find that when the inline version is short it's easier to read, otherwise I leave it multiline, like in coverage-linux.yml.
But if you prefer multiline arrays, there is no problem, I would put all arrays in multiline.
There was a problem hiding this comment.
yeah, I didn't put my comment on the best line. I don't feel strongly about the types and branches fields, but I would like at least the paths-ignore to stay multiline
.github/workflows/test-linux.yml
Outdated
| - v[0-9]+.x-staging | ||
| - v[0-9]+.x | ||
| branches: [master, main, canary, 'v[0-9]+.x-staging', 'v[0-9]+.x'] | ||
| paths-ignore: ['**.md', doc/**, AUTHORS, .mailmap, .github/**, '!.github/workflows/test-linux.yml'] |
There was a problem hiding this comment.
We want to run at least one build for doc changes -- at least one test checks for consistency between documentation and run time (hence needing a built node binary) behaviour:
There was a problem hiding this comment.
I think there are also addon tests that are built from the docs?
There was a problem hiding this comment.
- paths-ignore: ['**.md', doc/**, AUTHORS, .mailmap, .github/**, '!.github/workflows/test-linux.yml']
+ paths-ignore: ['AUTHORS, .mailmap, .github/**, '!.github/workflows/test-linux.yml']?
Reformat actions to maintain readability and consistency between different actions. Update some used actions (e.g. `actions/upload-artifact`). Rename misc action. Add more (complete) `path-ignores`. Use GitHub CLI when possible.
Mesteery
force-pushed
the
actions-update
branch
from
f528d81
to
74d8e7e
Compare
Reformat actions to maintain readability and consistency
between different actions.
Update some used actions (e.g.
actions/upload-artifact).Rename misc action.
Add more (complete)
path-ignores.