Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix regression in RSA-PSS keygen #39937

Closed
wants to merge 1 commit into from
Closed

crypto: fix regression in RSA-PSS keygen #39937

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

This regression was introduced in #35093. Node.js incorrectly adds RSASSA-PSS-params to RSA-PSS keys even when no parameters were specified by the user.

Fixes: #39936
Refs: #35093

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Aug 29, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39699/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39702/

@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Aug 30, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39706/

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 30, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39710/

panva pushed a commit that referenced this pull request Sep 1, 2021
@tniessen @panva
crypto: fix regression in RSA-PSS keygen
73d5f8a 
Fixes: #39936
Refs: #35093

PR-URL: #39937
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@panva
Copy link
Member

panva commented Sep 1, 2021

Landed in 73d5f8a

@panva panva closed this Sep 1, 2021
targos pushed a commit that referenced this pull request Sep 6, 2021
@tniessen @targos
crypto: fix regression in RSA-PSS keygen
936dbda 
Fixes: #39936
Refs: #35093

PR-URL: #39937
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2021
@tniessen @targos
crypto: fix regression in RSA-PSS keygen
5851994 
Fixes: #39936
Refs: #35093

PR-URL: #39937
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 6, 2021
Merged
codebytere added a commit to electron/electron that referenced this pull request Sep 8, 2021
@codebytere
crypto: fix regression in RSA-PSS keygen
6b8fbb3 
nodejs/node#39937
@tniessen tniessen deleted the crypto-fix-regression-in-key-pair-generation branch October 7, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RSA-PSS key pair generation incorrectly adds params since v15
6 participants
@tniessen @nodejs-github-bot @panva @jasnell @cjihrig @VoltrexKeyva