Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use Isolate::TryGetCurrent where appropriate #39954

Closed
wants to merge 2 commits into from
Closed

src: use Isolate::TryGetCurrent where appropriate #39954

wants to merge 2 commits into from

Commits on Aug 31, 2021

  1. src: use Isolate::TryGetCurrent where appropriate 

    In two places, we call `Isolate::GetCurrent()` even though that is
technically invalid usage of the function.
Now that V8 exposes `Isolate::TryGetCurrent()`, we can do this
in a proper way.
    @addaleax
    addaleax committed Aug 31, 2021
    Copy the full SHA
    52948a0 View commit details
    Browse the repository at this point in the history

  2. Revert "src: skip test_fatal/test_threads for Debug builds" 

    This reverts commit 1fc4d43.
    @addaleax
    addaleax committed Aug 31, 2021
    Copy the full SHA
    7f47ebf View commit details
    Browse the repository at this point in the history