Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add more to subsystems #39971

Closed
wants to merge 2 commits into from
Closed

doc: add more to subsystems #39971

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aba62a2
doc: add full list of subsystems
iam-frankqiu Sep 3, 2021
9cdf72c
doc: revise repo to repository
iam-frankqiu Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/guides/contributing/pull-requests.md
View file
Open in desktop
Expand Up @@ -579,6 +579,8 @@ If you want to know more about the code review and the landing process, see the
* `test`
* `tools`

You can find the full list of supported subsystems in the
[nodejs/core-validate-commit][] repo.
iam-frankqiu marked this conversation as resolved.
Show resolved Hide resolved
More than one subsystem may be valid for any particular issue or pull request.

[Building guide]: ../../../BUILDING.md
Expand All @@ -591,5 +593,6 @@ More than one subsystem may be valid for any particular issue or pull request.
[guide for writing tests in Node.js]: ../writing-tests.md
[hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment
[https://ci.nodejs.org/]: https://ci.nodejs.org/
[nodejs/core-validate-commit]: https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js
[pull request template]: https://raw.githubusercontent.com/nodejs/node/HEAD/.github/PULL_REQUEST_TEMPLATE.md
[running tests]: ../../../BUILDING.md#running-tests