Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x Backport] fs: writeFile support AsyncIterable, Iterable & Stream as data argument #39973

Closed
wants to merge 3 commits into from
Closed

[v14.x Backport] fs: writeFile support AsyncIterable, Iterable & Stream as data argument #39973

wants to merge 3 commits into from

Commits on Sep 1, 2021

  1. stream: move duplicated code to an internal module 

    Create a utils module for isIterable(), isReadable(), and isStream().

PR-URL: nodejs#37508
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @Trott @aduh95
    Trott authored and aduh95 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    2bcf3bc View commit details
    Browse the repository at this point in the history

  2. fs: add support for async iterators to fsPromises.writeFile 

    Fixes: nodejs#37391

PR-URL: nodejs#37490
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @aduh95
    HiroyukiYagihashi authored and aduh95 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    c4f6698 View commit details
    Browse the repository at this point in the history

  3. fs: add docs and tests for AsyncIterable support in fh.writeFile 

    Refs: nodejs#37490

PR-URL: nodejs#39836
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    @aduh95
    aduh95 committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    17b6ad6 View commit details
    Browse the repository at this point in the history