Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: make open and close stream override optional when unused #40013

Merged
merged 1 commit into from Sep 16, 2021
Merged

fs: make open and close stream override optional when unused #40013

merged 1 commit into from Sep 16, 2021

Commits on Sep 16, 2021

  1. fs: make open and close stream override optional when unused 

    When using `createReadStream` or `createWriteStream` with a specific
file descriptor or `FileHandle` instead of a path, `open` method is not
used, there is no point in forcing users to provide it.
When using `createReadStream` or `createWriteStream` with  `autoClose`
set to false, `close` method is not used, there is no point in forcing
users to provide it.

PR-URL: nodejs#40013
Reviewed-By: James M Snell <jasnell@gmail.com>
    @aduh95
    aduh95 committed Sep 16, 2021
    Copy the full SHA
    8a92018 View commit details
    Browse the repository at this point in the history