Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update Acorn to v8.5.0 #40015

Closed
wants to merge 1 commit into from
Closed

deps: update Acorn to v8.5.0 #40015

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 6, 2021

8.5.0 (2021-09-06)

Bug fixes

Improve context-dependent tokenization in a number of corner cases.

Fix location tracking after a 0x2028 or 0x2029 character in a string literal (which before did not increase the line number).

Fix an issue where arrow function bodies in for loop context would inappropriately consume in operators.

Fix wrong end locations stored on SequenceExpression nodes.

Implement restriction that for/of loop LHS can't start with let.

New features

Add support for ES2022 class static blocks.

Allow multiple input files to be passed to the CLI tool.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 6, 2021
@targos targos added dependencies Pull requests that update a dependency file. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 6, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2021
@nodejs-github-bot
Copy link
Collaborator

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 6, 2021
@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Sep 7, 2021
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM if CI is green

Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2021
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 8, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Landed in 59d3d54...9f6fed7

@github-actions github-actions bot closed this Sep 8, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 8, 2021
PR-URL: #40015
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos deleted the acorn-8.5 branch September 8, 2021 18:06
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #40015
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants