dns: refactor and use validators #40022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dns
VoltrexKeyva
force-pushed
the
patch-5
branch
3 times, most recently
from
44174a5
to
f9a76dd
Compare
jasnell
approved these changes
Sep 7, 2021
Ayase-252
approved these changes
Sep 15, 2021
Ayase-252
added
author ready
github-actions
bot
removed
the
request-ci
18 tasks
The logical NOT operator and validators should be used where appropriate.
VoltrexKeyva
force-pushed
the
patch-5
branch
from
f9a76dd
to
00d8ecb
Compare
|
Merge conflict resolved. |
18 tasks
17 tasks
targos
pushed a commit
that referenced
this pull request
Sep 18, 2021
The logical NOT operator and validators should be used where appropriate. PR-URL: #40022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
|
Landed in 7c77db0 |
This was referenced Sep 19, 2021
This was referenced Sep 23, 2021
|
Needs a backport PR to land on v16.x. |
targos
pushed a commit
that referenced
this pull request
Oct 9, 2021
The logical NOT operator and validators should be used where appropriate. PR-URL: #40022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
|
Actually landed in 03c2432. The conflict was easy. |
danielleadams
pushed a commit
that referenced
this pull request
Oct 12, 2021
The logical NOT operator and validators should be used where appropriate. PR-URL: #40022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logical NOT operator and validators should be used where appropriate.