Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: only lint version numbers for pull requests #40027

Closed
wants to merge 1 commit into from
Closed

build: only lint version numbers for pull requests #40027

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 7, 2021

Fixes: #39850

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 7, 2021
@targos
Copy link
Member Author

targos commented Sep 7, 2021 •
edited

BTW, I see that lint-md also runs the JS linter. Is that intended?

Running JS linter...
Running Markdown linter...

image

aduh95
aduh95 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@richardlau
Copy link
Member

BTW, I see that lint-md also runs the JS linter. Is that intended?

Running JS linter...
Running Markdown linter...

I believe so -- it's linting the JS within the docs:

node/Makefile

Lines 1254 to 1255 in dadea4a

# Lints the markdown documents maintained by us in the codebase.
lint-md: lint-js-doc | tools/.mdlintstamp

node/Makefile

Lines 1269 to 1279 in dadea4a

.PHONY: lint-js-doc
# Note that on the CI `lint-js-ci` is run instead.
# Lints the JavaScript code with eslint.
lint-js-doc: LINT_JS_TARGETS=doc
lint-js lint-js-doc:
@if [ "$(shell $(node_use_openssl))" != "true" ]; then \
echo "Skipping $@ (no crypto)"; \
else \
echo "Running JS linter..."; \
$(call available-node,$(run-lint-js)) \
fi

@VoltrexKeyva VoltrexKeyva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 10, 2021
@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2021
@github-actions
Copy link
Contributor

Landed in bbd4c6e...798c0cb

@github-actions github-actions bot closed this Sep 15, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 15, 2021
@targos @nodejs-github-bot
build: only lint version numbers for pull requests
798c0cb 
Fixes: #39850

PR-URL: #40027
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos deleted the fix-lint-md branch September 15, 2021 06:53
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos @BethGriggs
build: only lint version numbers for pull requests
49f77b5 
Fixes: #39850

PR-URL: #40027
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos @BethGriggs
build: only lint version numbers for pull requests
01b1946 
Fixes: #39850

PR-URL: #40027
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make lint-md failing for v16.x-staging in GitHub actions
7 participants
@targos @richardlau @jasnell @lpinca @aduh95 @nodejs-github-bot @VoltrexKeyva