Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: register zlib external references for snapshot #40050

Closed
wants to merge 1 commit into from
Closed

src: register zlib external references for snapshot #40050

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Another spin-off of #38905

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Sep 9, 2021
mhdawson
mhdawson approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39944/

@VoltrexKeyva VoltrexKeyva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Sep 16, 2021
@mhdawson
Copy link
Member

@joyeecheung I'm assuming this is not SemVer minor, but I thought I'd just ask that you confirm and tag it if I'm wrong on that.

@mhdawson
Copy link
Member

Landed in 58b7d47

@mhdawson mhdawson closed this Sep 16, 2021
mhdawson pushed a commit that referenced this pull request Sep 16, 2021
@joyeecheung @mhdawson
src: register zlib external references for snapshot
58b7d47 
PR-URL: #40050
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@joyeecheung @BethGriggs
src: register zlib external references for snapshot
27232c0 
PR-URL: #40050
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@joyeecheung @BethGriggs
src: register zlib external references for snapshot
31994fb 
PR-URL: #40050
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@XadillaX XadillaX XadillaX approved these changes

@tniessen tniessen tniessen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@joyeecheung @nodejs-github-bot @mhdawson @jasnell @addaleax @XadillaX @tniessen @juanarbol @VoltrexKeyva