Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: expand paths-ignore to include .mailmap/AUTHORS for long-running and/or flaky workflows #40109

Closed
wants to merge 3 commits into from
Closed

build: expand paths-ignore to include .mailmap/AUTHORS for long-running and/or flaky workflows #40109

wants to merge 3 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 14, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 14, 2021
mhdawson
mhdawson approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 14, 2021
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2021
@github-actions
Copy link
Contributor

Landed in d23079d...0f1765e

@github-actions github-actions bot closed this Sep 16, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 16, 2021
@Trott @nodejs-github-bot
build: add paths-ignore for build-tarball workflow
ecb6c84 
In GitHub Actions, don't run build-tarball if the only changed files are
docs.

PR-URL: #40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Sep 16, 2021
@Trott @nodejs-github-bot
build: add .mailmap/AUTHORS to path-ignore for test-asan
884b478 
PR-URL: #40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Sep 16, 2021
@Trott @nodejs-github-bot
build: add .mailmap/AUTHORS to paths-ignore for test-macos
0f1765e 
PR-URL: #40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Trott @BethGriggs
build: add paths-ignore for build-tarball workflow
92af047 
In GitHub Actions, don't run build-tarball if the only changed files are
docs.

PR-URL: #40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Trott @BethGriggs
build: add .mailmap/AUTHORS to path-ignore for test-asan
e14ca40 
PR-URL: #40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Trott @BethGriggs
build: add .mailmap/AUTHORS to paths-ignore for test-macos
7f005e5 
PR-URL: #40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Trott @BethGriggs
build: add paths-ignore for build-tarball workflow
886921d 
In GitHub Actions, don't run build-tarball if the only changed files are
docs.

PR-URL: #40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Trott @BethGriggs
build: add .mailmap/AUTHORS to path-ignore for test-asan
9793e7f 
PR-URL: #40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Trott @BethGriggs
build: add .mailmap/AUTHORS to paths-ignore for test-macos
8d5787a 
PR-URL: #40109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
@Trott Trott deleted the paths-ignore branch September 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@mhdawson mhdawson mhdawson approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Trott @jasnell @mhdawson @aduh95 @nodejs-github-bot