Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move one or more collaborators to emeritus #40115

Merged
merged 1 commit into from Sep 30, 2021

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/find-inactive-collaborators.yml.

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Sep 15, 2021
@tniessen tniessen requested a review from Trott September 15, 2021 07:53
@Trott
Copy link
Member

Trott commented Sep 15, 2021

@bmeurer @geek @misterdjules @refack @saghul @yorkie This automated job has identified you as someone who has not been involved (as author, reviewer, or committer) in the last 5000 commits (spanning nearly the last 20 months). However, you cannot be moved to emeritus unless you voluntarily do it or the TSC decides to move you.

So, given that, can you indicate whether you would like to be moved to emeritus at this time or not? If you wish to remain as an active collaborator, I will remove you from this PR manually.

@Trott Trott added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Sep 15, 2021
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@misterdjules
Copy link

@Trott I'm totally fine being moved to emeritus or having my info deleted if it helps in any way.

@Trott
Copy link
Member

Trott commented Sep 23, 2021

@nodejs/tsc Reviews on this would be great.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bmeurer
Copy link
Member

bmeurer commented Sep 28, 2021

LGTM

@saghul
Copy link
Member

saghul commented Sep 28, 2021

LGTM, happy to be moved to emeritus. Still rooting for Node 🚀

@Trott Trott force-pushed the create-or-update-pull-request-action branch from a22944d to 0816f0b Compare September 29, 2021 14:36
@Trott
Copy link
Member

Trott commented Sep 29, 2021

@nodejs/tsc In the interest of closing out this PR (which has been open for approximately two weeks), this is a call for a vote on moving refack to emeritus. Please react with 👍 for yes, 👎 for no, and any other emoji to abstain. Thanks.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2021
@Trott
Copy link
Member

Trott commented Sep 30, 2021

@nodejs/tsc In the interest of closing out this PR (which has been open for approximately two weeks), this is a call for a vote on moving refack to emeritus. Please react with 👍 for yes, 👎 for no, and any other emoji to abstain. Thanks.

With 11 TSC votes in favor (me, ronag, mcollina, apapirovski, aduh95, cjihrig, targos, BridgeAR, fhinkel, jasnell, mhdawson) and 21 current members on the TSC, this passes and the PR can now land.

@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 30, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40115
✔  Done loading data for nodejs/node/pull/40115
----------------------------------- PR info ------------------------------------
Title      meta: move one or more collaborators to emeritus (#40115)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:create-or-update-pull-request-action -> nodejs:master
Labels     doc, meta, tsc-agenda
Commits    1
 - meta: move one or more collaborators to emeritus
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40115
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Yorkie Liu 
Reviewed-By: Beth Griggs 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Robert Nagy 
Reviewed-By: Colin Ihrig 
Reviewed-By: Matteo Collina 
Reviewed-By: Myles Borins 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Wyatt Preul 
Reviewed-By: Saúl Ibarra Corretgé 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Benedikt Meurer 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40115
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Yorkie Liu 
Reviewed-By: Beth Griggs 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Robert Nagy 
Reviewed-By: Colin Ihrig 
Reviewed-By: Matteo Collina 
Reviewed-By: Myles Borins 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Wyatt Preul 
Reviewed-By: Saúl Ibarra Corretgé 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Benedikt Meurer 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 15 Sep 2021 04:12:08 GMT
   ✔  Approvals: 20
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-755240501
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-755499475
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40115#pullrequestreview-755509931
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-756331114
   ✔  - Yorkie Liu (@yorkie): https://github.com/nodejs/node/pull/40115#pullrequestreview-761277490
   ✔  - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-762313906
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-762367547
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-762384861
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-762388564
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-762391809
   ✔  - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-762431656
   ✔  - Сковорода Никита Андреевич (@ChALkeR) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-762590960
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-762594856
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-763669303
   ✔  - Wyatt Preul (@geek): https://github.com/nodejs/node/pull/40115#pullrequestreview-763821494
   ✔  - Saúl Ibarra Corretgé (@saghul): https://github.com/nodejs/node/pull/40115#pullrequestreview-765335833
   ✔  - Anatoli Papirovski (@apapirovski) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-766838781
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-767162750
   ✔  - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/40115#pullrequestreview-767165738
   ✔  - Benedikt Meurer (@bmeurer): LGTM
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1289195381

PR-URL: #40115
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <s@saghul.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 30, 2021

Landed in e883a16

@Trott Trott force-pushed the create-or-update-pull-request-action branch from 0816f0b to e883a16 Compare September 30, 2021 01:37
@Trott Trott merged commit e883a16 into master Sep 30, 2021
@targos targos deleted the create-or-update-pull-request-action branch September 30, 2021 02:54
targos pushed a commit that referenced this pull request Oct 4, 2021
PR-URL: #40115
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <s@saghul.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet