src: remove usage of AllocatedBuffer from udp_wrap.cc
#40151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
RaisinTen
force-pushed
the
src/remove-usage-of-AllocatedBuffer-from-udp_wrap.cc
branch
from
3b8daf8
to
755a3fe
Compare
This comment has been minimized.
This comment has been minimized.
tniessen
approved these changes
Sep 19, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen
added
author ready
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Sep 20, 2021
addaleax
reviewed
Sep 21, 2021
RaisinTen
removed
the
author ready
This comment has been minimized.
This comment has been minimized.
addaleax
reviewed
Sep 22, 2021
This was referenced Sep 23, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen
force-pushed
the
src/remove-usage-of-AllocatedBuffer-from-udp_wrap.cc
branch
from
c2715b8
to
1865ace
Compare
addaleax
approved these changes
Sep 24, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen
added
the
author ready
17 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
21 tasks
RaisinTen
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 256fe21...95d1656 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 26, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40151 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
RaisinTen
deleted the
src/remove-usage-of-AllocatedBuffer-from-udp_wrap.cc
branch
This was referenced Sep 27, 2021
22 tasks
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40151 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen darshan.sen@postman.com