doc: update tools .md files for upcoming lint/formatting #40155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
i18n-api
aduh95
approved these changes
Sep 19, 2021
targos
approved these changes
Sep 20, 2021
Trott
added
the
author ready
jasnell
approved these changes
Sep 20, 2021
Trott
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40155 ✔ Done loading data for nodejs/node/pull/40155 ----------------------------------- PR info ------------------------------------ Title doc: update tools .md files for upcoming lint/formatting (#40155) Author Rich Trott (@Trott) Branch Trott:tools-md -> nodejs:master Labels tools, i18n-api, author ready, needs-ci, icu Commits 1 - doc: update tools .md files for upcoming lint/formatting Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40155 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40155 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 19 Sep 2021 19:50:26 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40155#pullrequestreview-758189003 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40155#pullrequestreview-758347359 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40155#pullrequestreview-758696742 ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1259413001 |
Looks like only one .md file in `tools` needs to be changed. PR-URL: nodejs#40155 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 0c95dea |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
Looks like only one .md file in `tools` needs to be changed. PR-URL: #40155 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like only one .md file in
toolsneeds to be changed.