doc: update benchmarks README.md for upcoming linting/formatting #40158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
benchmark
Trott
changed the title
targos
approved these changes
Sep 20, 2021
aduh95
approved these changes
Sep 20, 2021
Trott
added
the
author ready
jasnell
approved these changes
Sep 20, 2021
lpinca
approved these changes
Sep 21, 2021
lpinca
reviewed
Sep 21, 2021
benchmark/README.md
Outdated
| @@ -32,7 +32,7 @@ directory, see [the guide on benchmarks](../doc/guides/writing-and-running-bench | |||
| | module | Benchmarks for the `module` subsystem. | | |||
| | net | Benchmarks for the `net` subsystem. | | |||
| | path | Benchmarks for the `path` subsystem. | | |||
| | perf_hooks | Benchmarks for the `perf_hooks` subsystem. | | |||
| | perf\_hooks | Benchmarks for the `perf_hooks` subsystem. | | |||
There was a problem hiding this comment.
Suggested change
| | perf\_hooks | Benchmarks for the `perf_hooks` subsystem. | | |
| | perf\_hooks | Benchmarks for the `perf_hooks` subsystem. | |
There was a problem hiding this comment.
Fixed. Thanks. I'm pretty sure that consistent alignment of pipes in the text representation of tables is something that can be configured in the formatter, so I'll look into doing that.
There was a problem hiding this comment.
Turns out it's the default with remark-gfm which we use in the linter, so this will happen automatically when we start using the linter for the formatter. I was omitting gfm when running remark on the command line, but I won't do that in subsequent PRs. Thanks again!
PR-URL: nodejs#40158 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in a6a5d4b |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
PR-URL: #40158 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.