Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typos in http.md #40161

Closed
wants to merge 1 commit into from
Closed

doc: fix typos in http.md #40161

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Sep 20, 2021

reach -> reached.
closed -> close.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Sep 20, 2021
doc/api/http.md Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca changed the title doc: fix typo in http.md doc: fix typos in http.md Sep 20, 2021
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 22, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40161
✔  Done loading data for nodejs/node/pull/40161
----------------------------------- PR info ------------------------------------
Title      doc: fix typos in http.md (#40161)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     lpinca:fix/typo -> nodejs:master
Labels     http, doc
Commits    1
 - doc: fix typos in http.md
Committers 1
 - Luigi Pinca 
PR-URL: https://github.com/nodejs/node/pull/40161
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40161
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - doc: fix typos in http.md
   ℹ  This PR was created on Mon, 20 Sep 2021 09:32:10 GMT
   ✔  Approvals: 3
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40161#pullrequestreview-758623968
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40161#pullrequestreview-758697511
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40161#pullrequestreview-758748071
   ✔  Last GitHub Actions successful
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1262934779

lpinca added a commit that referenced this pull request Sep 22, 2021
PR-URL: #40161
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@lpinca
Copy link
Member Author

lpinca commented Sep 22, 2021

Landed in e1bca10.

@lpinca lpinca closed this Sep 22, 2021
@lpinca lpinca deleted the fix/typo branch September 22, 2021 18:10
targos pushed a commit that referenced this pull request Oct 4, 2021
PR-URL: #40161
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants