Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update remark-preset-lint-node to 3.1.0 #40166

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 20, 2021

Update remark-preset-lint-node from 3.0.1 to 3.1.0. This is a necessary
step before we can use the lint preset to format markdown files.

Update remark-preset-lint-node from 3.0.1 to 3.1.0. This is a necessary
step before we can use the lint preset to format markdown files.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 20, 2021
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 21, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 22, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40166
✔  Done loading data for nodejs/node/pull/40166
----------------------------------- PR info ------------------------------------
Title      tools: update remark-preset-lint-node to 3.1.0 (#40166)
Author     Rich Trott  (@Trott)
Branch     Trott:format-pre -> nodejs:master
Labels     tools, author ready
Commits    1
 - tools: update remark-preset-lint-node to 3.1.0
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40166
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40166
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 20 Sep 2021 18:56:22 GMT
   ✔  Approvals: 1
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40166#pullrequestreview-759197535
   ✖  This PR needs to wait 117 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub Actions successful
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1263549090

@Trott Trott removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 22, 2021
@Trott
Copy link
Member Author

Trott commented Sep 22, 2021

@nodejs/linting This could use a second review/approval.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2021
@github-actions
Copy link
Contributor

Landed in c89d519...51d2623

@github-actions github-actions bot closed this Sep 22, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 22, 2021
Update remark-preset-lint-node from 3.0.1 to 3.1.0. This is a necessary
step before we can use the lint preset to format markdown files.

PR-URL: #40166
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Oct 4, 2021
Update remark-preset-lint-node from 3.0.1 to 3.1.0. This is a necessary
step before we can use the lint preset to format markdown files.

PR-URL: #40166
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott Trott deleted the format-pre branch September 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants