v16.10.0 proposal

.github/workflows/authors.yml

@@ -1,5 +1,9 @@
 name: "authors update"
 on:
+  schedule:
+    # Run once a week at 00:05 AM UTC on Sunday.
+    - cron: '5 0 * * 0'
+
   workflow_dispatch:
 
 jobs:

.github/workflows/build-tarball.yml

@@ -3,12 +3,22 @@ name: Build from tarball
 on:
   pull_request:
     types: [opened, synchronize, reopened, ready_for_review]
+    paths-ignore:
+      - '.mailmap'
+      - '**.md'
+      - 'AUTHORS'
+      - 'doc/**'
   push:
     branches:
       - master
       - main
       - v[0-9]+.x-staging
       - v[0-9]+.x
+    paths-ignore:
+      - '.mailmap'
+      - '**.md'
+      - 'AUTHORS'
+      - 'doc/**'
 
 env:
   FLAKY_TESTS: dontcare

.github/workflows/build-windows.yml

@@ -18,7 +18,11 @@ env:
 jobs:
   build-windows:
     if: github.event.pull_request.draft == false
-    runs-on: windows-latest
+    strategy:
+      matrix:
+        windows: [windows-2019, windows-2022]
+      fail-fast: false
+    runs-on: ${{ matrix.windows }}
     steps:
       - uses: actions/checkout@v2
       - name: Set up Python ${{ env.PYTHON_VERSION }}

.github/workflows/comment-labeled.yml

@@ -12,7 +12,7 @@ jobs:
     steps:
       - name: Post stalled comment
         env:
-            COMMENTS_URL: ${{ github.event.issue.comments_url || github.event.pull_request.comments_url }}
+          COMMENTS_URL: ${{ github.event.issue.comments_url || github.event.pull_request.comments_url }}
         run: |
           curl -X POST $COMMENTS_URL \
           -H "Content-Type: application/json" \

.github/workflows/coverage-linux.yml

@@ -45,7 +45,7 @@ jobs:
       - name: Report JS
         run: npx c8 report --check-coverage
         env:
-           NODE_OPTIONS: --max-old-space-size=8192
+          NODE_OPTIONS: --max-old-space-size=8192
       - name: Report C++
         run: cd out && gcovr --gcov-exclude='.*\b(deps|usr|out|obj|cctest|embedding)\b' -v -r Release/obj.target --xml -o ../coverage/coverage-cxx.xml --root=$(cd ../ && pwd)
       # Clean temporary output from gcov and c8, so that it's not uploaded:

.github/workflows/find-inactive-collaborators.yml

@@ -13,7 +13,7 @@ env:
 
 jobs:
   find:
-  
+
     runs-on: ubuntu-latest
 
     steps:

.github/workflows/linters.yml

@@ -53,7 +53,7 @@ jobs:
       - name: Environment Information
         run: npx envinfo
       - name: Get release version numbers
-        if: ${{ github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }}
+        if: ${{ github.event.pull_request && github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }}
         id: get-released-versions
         run: ./tools/node-lint-md-cli-rollup/src/list-released-versions-from-changelogs.mjs
       - name: Lint docs
@@ -90,7 +90,23 @@ jobs:
       - name: Lint Python
         run: |
           make lint-py-build || true
-          NODE=$(command -v node) make lint-py
+          make lint-py
+  lint-yaml:
+    if: github.event.pull_request.draft == false
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v2
+        with:
+          python-version: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Lint YAML
+        run: |
+          make lint-yaml-build || true
+          make lint-yaml
+
   lint-sh:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-20.04

.github/workflows/notify-force-push.yml

@@ -11,16 +11,16 @@ jobs:
     if: ${{ github.event.forced && github.repository == 'nodejs/node' }}
     runs-on: ubuntu-latest
     steps:
-    - name: Slack Notification
-      uses: rtCamp/action-slack-notify@master
-      env:
-        SLACK_COLOR: '#DE512A'
-        SLACK_ICON: https://github.com/nodejs.png?size=48
-        SLACK_TITLE: '${{ github.actor }} force-pushed to ${{ github.ref }}'
-        SLACK_MESSAGE: |
-          A commit was force-pushed to <https://github.com/${{ github.repository }}/tree/${{ github.repository.default_branch }}|${{ github.repository }}@${{ github.repository.default_branch }}> by <https://github.com/${{ github.actor }}|${{ github.actor }}>
+      - name: Slack Notification
+        uses: rtCamp/action-slack-notify@master
+        env:
+          SLACK_COLOR: '#DE512A'
+          SLACK_ICON: https://github.com/nodejs.png?size=48
+          SLACK_TITLE: '${{ github.actor }} force-pushed to ${{ github.ref }}'
+          SLACK_MESSAGE: |
+            A commit was force-pushed to <https://github.com/${{ github.repository }}/tree/${{ github.repository.default_branch }}|${{ github.repository }}@${{ github.repository.default_branch }}> by <https://github.com/${{ github.actor }}|${{ github.actor }}>
 
-          Before: <https://github.com/${{ github.repository }}/commit/${{ github.event.before }}|${{ github.event.before }}>
-          After: <https://github.com/${{ github.repository }}/commit/${{ github.event.after }}|${{ github.event.after }}>
-        SLACK_USERNAME: nodejs-bot
-        SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
+            Before: <https://github.com/${{ github.repository }}/commit/${{ github.event.before }}|${{ github.event.before }}>
+            After: <https://github.com/${{ github.repository }}/commit/${{ github.event.after }}|${{ github.event.after }}>
+          SLACK_USERNAME: nodejs-bot
+          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}

.github/workflows/test-asan.yml

@@ -1,6 +1,13 @@
 name: test-asan
 
 on:
+  pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
+    paths-ignore:
+      - '.mailmap'
+      - '**.md'
+      - 'AUTHORS'
+      - 'doc/**'
   push:
     branches:
       - master
@@ -9,12 +16,9 @@ on:
       - v[0-9]+.x-staging
       - v[0-9]+.x
     paths-ignore:
+      - '.mailmap'
       - '**.md'
-      - 'doc/**'
-  pull_request:
-    types: [opened, synchronize, reopened, ready_for_review]
-    paths-ignore:
-      - '**.md'
+      - 'AUTHORS'
       - 'doc/**'
 
 env:

.github/workflows/test-internet.yml

@@ -0,0 +1,40 @@
+name: test-internet
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: 5 0 * * *
+
+pull_request:
+  types: [opened, synchronize, reopened, ready_for_review]
+  paths:
+    - test/internet/**
+  push:
+    branches:
+      - master
+      - main
+      - canary
+      - v[0-9]+.x-staging
+      - v[0-9]+.x
+    paths:
+      - test/internet/**
+
+env:
+  PYTHON_VERSION: 3.9
+  FLAKY_TESTS: dontcare
+
+jobs:
+  test-internet:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v2
+        with:
+          python-version: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Build
+        run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
+      - name: Test Internet
+        run: make test-internet -j2 V=1;

.github/workflows/test-macos.yml

@@ -4,7 +4,9 @@ on:
   pull_request:
     types: [opened, synchronize, reopened, ready_for_review]
     paths-ignore:
+      - '.mailmap'
       - '**.md'
+      - 'AUTHORS'
       - 'doc/**'
   push:
     branches:
@@ -14,7 +16,9 @@ on:
       - v[0-9]+.x-staging
       - v[0-9]+.x
     paths-ignore:
+      - '.mailmap'
       - '**.md'
+      - 'AUTHORS'
       - 'doc/**'
 
 env:

.gitignore

@@ -9,18 +9,19 @@
 !deps/**/.*
 !test/fixtures/**/.*
 !.clang-format
+!.cpplint
 !.editorconfig
 !.eslintignore
 !.eslintrc.js
+!.eslintrc.yaml
 !.flake8
 !.gitattributes
 !.github
 !.gitignore
 !.gitkeep
 !.mailmap
 !.nycrc
-!.eslintrc.yaml
-!.cpplint
+!.yamllint.yaml
 
 # === Rules for root dir ===
 /core

.mailmap

@@ -150,6 +150,8 @@ Gabriel de Perthuis <g2p.code@gmail.com>
 Gareth Ellis <gareth.ellis@uk.ibm.com> <gareth@gsellis.com>
 Garwah Lam <garwahlam@gmail.com>
 garygsc <garygsc@gmail.com> <GaryGSC@users.noreply.github.com>
+Geoffrey Booth <webadmin@geoffreybooth.com> <GeoffreyBooth@users.noreply.github.com>
+Geoffrey Booth <webadmin@geoffreybooth.com> <webmaster@geoffreybooth.com>
 Geoffrey Bugaisky <gbugaisk@gmail.com>
 Gerhard Stöbich <deb2001-github@yahoo.de>
 Gibson Fahnestock <gibfahn@gmail.com> <gib@uk.ibm.com>
@@ -247,9 +249,11 @@ Kris Kowal <kris.kowal@cixar.com>
 Kyle Robinson Young <kyle@dontkry.com>
 Lakshmi Swetha Gopireddy <lakshmiswethagopireddy@gmail.com> <lgopired@in.ibm.com>
 Leeseean Chiu <leeseean@qq.com>
+Lucas Pardue <lucaspardue.24.7@gmail.com> <lucas.pardue@bbc.co.uk>
 Luke Bayes <lbayes@patternpark.com>
 Lydia Kats <llkats@gmail.com>
 Maciej Małecki <maciej.malecki@notimplemented.org> <me@mmalecki.com>
+Maël Nison <nison.mael@gmail.com> <mael@fb.com>
 MaleDong <maledong_github@outlook.com> <maledong_private@qq.com>
 Malte-Thorben Bruns <skenqbx@gmail.com>
 Malte-Thorben Bruns <skenqbx@gmail.com> <skenqbx@googlemail.com>
@@ -287,12 +291,16 @@ Micleusanu Nicu <micnic90@gmail.com>
 Miguel Angel Asencio Hurtado <maasencioh@gmail.com>
 Mikael Bourges-Sevenier <mikeseven@gmail.com> <msevenier@motorola.com>
 Mike Kaufman <mike.kaufman@microsoft.com> <mkaufman@microsoft.com>
+Mike MacCana <mike.maccana@gmail.com> <mike@certsimple.com>
 Minqi Pan <pmq2001@gmail.com>
 Minuk Park <parkm86@gmail.com>
 Minwoo Jung <nodecorelab@gmail.com> <jmwsoft@gmail.com>
 Minwoo Jung <nodecorelab@gmail.com> <minwoo@nodesource.com>
-Miroslav Bajtoš <miroslav@strongloop.com> <miro.bajtos@gmail.com>
+Miroslav Bajtoš <oss@bajtos.net> <mbajtoss@gmail.com>
+Miroslav Bajtoš <oss@bajtos.net> <miro.bajtos@gmail.com>
+Miroslav Bajtoš <oss@bajtos.net> <miroslav@strongloop.com>
 Mitar Milutinovic <mitar.git@tnode.com>
+Mithun Sasidharan <mithunsasidharan89@gmail.com> <msasidharan@paypal.com>
 Myles Borins <myles.borins@gmail.com> <mborins@us.ibm.com>
 Myles Borins <myles.borins@gmail.com> <mylesborins@github.com>
 Myles Borins <myles.borins@gmail.com> <mylesborins@google.com>

.yamllint.yaml

@@ -0,0 +1,8 @@
+extends: relaxed
+
+rules:
+  line-length: disable
+
+ignore: |
+  /deps/
+  node_modules/