tools: re-implement lint-md without unified-args #40180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
aduh95
approved these changes
Sep 22, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
18 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Trott
force-pushed
the
de-rollup-again
branch
from
0cf5936
to
84981f3
Compare
This comment has been minimized.
This comment has been minimized.
Trott
force-pushed
the
de-rollup-again
branch
from
84981f3
to
cc5807d
Compare
This comment has been minimized.
This comment has been minimized.
`unified-args` ignores settings in the preset, expecting them to be in remarkrc files or passed on the command line instead. Realizing that we always send the same configuration options via the command-line anyway, this removes `unified-args`. This means the preset settings are now respected and it removes nearly 30000 lines of code in the resulting rollup file. I wasn't sure I was going to want to keep rollup so I started re-implementing this without it, but ended up putting a minimal rollup back as it still saves about 90000 lines of code vs. checking in `node_modules`.
Trott
force-pushed
the
de-rollup-again
branch
from
cc5807d
to
4bbb621
Compare
jasnell
approved these changes
Sep 23, 2021
Trott
added
the
author ready
This was referenced Sep 24, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 8006586...8d83c47 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 25, 2021
`unified-args` ignores settings in the preset, expecting them to be in remarkrc files or passed on the command line instead. Realizing that we always send the same configuration options via the command-line anyway, this removes `unified-args`. This means the preset settings are now respected and it removes nearly 30000 lines of code in the resulting rollup file. I wasn't sure I was going to want to keep rollup so I started re-implementing this without it, but ended up putting a minimal rollup back as it still saves about 90000 lines of code vs. checking in `node_modules`. PR-URL: #40180 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 26, 2021
22 tasks
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
`unified-args` ignores settings in the preset, expecting them to be in remarkrc files or passed on the command line instead. Realizing that we always send the same configuration options via the command-line anyway, this removes `unified-args`. This means the preset settings are now respected and it removes nearly 30000 lines of code in the resulting rollup file. I wasn't sure I was going to want to keep rollup so I started re-implementing this without it, but ended up putting a minimal rollup back as it still saves about 90000 lines of code vs. checking in `node_modules`. PR-URL: #40180 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unified-argsignores settings in the preset, expecting them to be inremarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes
unified-args. This means the preset settings arenow respected and it removes nearly over 28000 lines of code in the resulting
rollup file.
I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
node_modules.