Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: use 0 as default for requests limit #40192

Closed
wants to merge 2 commits into from
Closed

http: use 0 as default for requests limit #40192

wants to merge 2 commits into from

Conversation

fatal10110
Copy link
Contributor

closes #40190

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Sep 23, 2021
mcollina
mcollina reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

@fatal10110
Copy link
Contributor Author

I think default value is tested here already
https://github.com/nodejs/node/blob/master/test/parallel/test-http-keep-alive.js

I can add a test that tests a "null" value

@fatal10110
Copy link
Contributor Author

I think default value is tested here already

Nvm, I was wrong, im not sure what is tested there, I will write my own test

mcollina
mcollina approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40055/

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 26, 2021
XadillaX
XadillaX approved these changes Sep 26, 2021
View reviewed changes
Copy link
Member

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major or patch?

@mcollina
Copy link
Member

I would go with patch, this a bug/oversight.

mcollina pushed a commit that referenced this pull request Sep 27, 2021
@fatal10110 @mcollina
http: use 0 as default for requests limit
44b173e 
PR-URL: #40192
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@mcollina
Copy link
Member

Landed in 44b173e

@mcollina mcollina closed this Sep 27, 2021
@fatal10110 fatal10110 mentioned this pull request Sep 28, 2021
Closed
targos pushed a commit that referenced this pull request Oct 4, 2021
@fatal10110 @targos
http: use 0 as default for requests limit
22725f5 
PR-URL: #40192
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@XadillaX XadillaX XadillaX approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lack of consistency in maxRequestPerSocket
6 participants
@fatal10110 @nodejs-github-bot @mcollina @jasnell @XadillaX @targos