Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: reorder stream 'readable' paragraphs #40212

Closed
wants to merge 1 commit into from
Closed

doc: reorder stream 'readable' paragraphs #40212

wants to merge 1 commit into from

Conversation

vweevers
Copy link
Contributor

Fixes: #40136

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Sep 25, 2021
mcollina
mcollina approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40062/

@github-actions github-actions bot mentioned this pull request Sep 26, 2021
Open
21 tasks
@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 26, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40073/

@github-actions github-actions bot mentioned this pull request Sep 27, 2021
Open
21 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40088/

This was referenced Sep 28, 2021
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40111/

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2021
@github-actions
Copy link
Contributor

Landed in 140b25a...1e89238

@github-actions github-actions bot closed this Sep 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 30, 2021
@vweevers @nodejs-github-bot
doc: reorder stream 'readable' paragraphs
1e89238 
Fixes: #40136

PR-URL: #40212
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@vweevers vweevers deleted the stream-readable-docs branch September 30, 2021 19:23
This was referenced Oct 1, 2021
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Oct 4, 2021
@vweevers @targos
doc: reorder stream 'readable' paragraphs
d2e54e5 
Fixes: #40136

PR-URL: #40212
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
This was referenced Oct 5, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@antsmartian antsmartian antsmartian approved these changes

@cjihrig cjihrig cjihrig approved these changes

@ronag ronag ronag approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readable event triggers but socket.readableLength returns zero
9 participants
@vweevers @nodejs-github-bot @mcollina @jasnell @antsmartian @cjihrig @ronag @tniessen @targos