Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove usage of AllocatedBuffer from crypto_common.cc #40213

Closed
wants to merge 1 commit into from
Closed

src: remove usage of AllocatedBuffer from crypto_common.cc #40213

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

@RaisinTen
src: remove usage of AllocatedBuffer from crypto_common.cc
942b36d 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 25, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen removed the needs-ci PRs that need a full CI run. label Sep 25, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40070/

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2021
This was referenced Sep 26, 2021
Open
Open
@github-actions github-actions bot mentioned this pull request Sep 28, 2021
Open
18 tasks
XadillaX pushed a commit that referenced this pull request Sep 28, 2021
@RaisinTen @XadillaX
src: remove AllocatedBuffer from crypto_common.cc
2caa308 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40213
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@XadillaX
Copy link
Member

XadillaX commented Sep 28, 2021 •
edited

Landed in 2caa308

@XadillaX XadillaX closed this Sep 28, 2021
@RaisinTen RaisinTen deleted the src/remove-usage-of-AllocatedBuffer-from-crypto_common.cc branch September 28, 2021 12:21
This was referenced Sep 29, 2021
Open
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Oct 4, 2021
@RaisinTen @targos
src: remove AllocatedBuffer from crypto_common.cc
bbf1ed7 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40213
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
@github-actions github-actions bot mentioned this pull request Oct 5, 2021
Open
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@XadillaX XadillaX XadillaX approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RaisinTen @nodejs-github-bot @XadillaX @jasnell