Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix the example of crypto.generateKeySync #40225

Closed
wants to merge 1 commit into from
Closed

doc: fix the example of crypto.generateKeySync #40225

wants to merge 1 commit into from

Conversation

GreenSleepes
Copy link
Contributor

doc: fix the example of crypto.generateKeySync

The "options" argument must be an object.

doc: fix the example of crypto.generateKeySync

The "options" argument must be an object.
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Sep 27, 2021
Copy link
Member

@Ayase-252 Ayase-252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution.

@Ayase-252 Ayase-252 added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 27, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Ayase-252. Please 👍 to approve.

panva pushed a commit that referenced this pull request Sep 27, 2021
doc: fix the example of crypto.generateKeySync

The "options" argument must be an object.

PR-URL: #40225
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@panva
Copy link
Member

panva commented Sep 27, 2021

Landed in 8037d17. Thanks you for your contribution.

@panva panva closed this Sep 27, 2021
targos pushed a commit that referenced this pull request Oct 4, 2021
doc: fix the example of crypto.generateKeySync

The "options" argument must be an object.

PR-URL: #40225
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants