Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8: remove --harmony-top-level-await #40226

Closed
wants to merge 1 commit into from
Closed

v8: remove --harmony-top-level-await #40226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/node.cc
View file
Open in desktop
Expand Up @@ -803,13 +803,6 @@ int ProcessGlobalArgs(std::vector<std::string>* args,
return 12;
}

// TODO(mylesborins): remove this when the harmony-top-level-await flag
// is removed in V8
if (std::find(v8_args.begin(), v8_args.end(),
"--no-harmony-top-level-await") == v8_args.end()) {
v8_args.push_back("--harmony-top-level-await");
}

auto env_opts = per_process::cli_options->per_isolate->per_env;
if (std::find(v8_args.begin(), v8_args.end(),
"--abort-on-uncaught-exception") != v8_args.end() ||
Expand Down
4 changes: 0 additions & 4 deletions test/message/esm_display_syntax_error.mjs
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions test/message/esm_display_syntax_error.out
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions test/parallel/test-no-harmony-top-level-await.mjs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tools/code_cache/mkcodecache.cc
View file
Open in desktop
Expand Up @@ -28,7 +28,6 @@ int main(int argc, char* argv[]) {
#endif // _WIN32

v8::V8::SetFlagsFromString("--random_seed=42");
v8::V8::SetFlagsFromString("--harmony-top-level-await");

if (argc < 2) {
std::cerr << "Usage: " << argv[0] << " <path/to/output.cc>\n";
Expand Down