Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x backport] crypto: make FIPS related options always awailable #40241

Closed

Commits on Sep 28, 2021

  1. crypto: make FIPS related options always awailable

    There is no reason to hide FIPS functionality behind build flags.
    OpenSSL always provide the information about FIPS availability via
    `FIPS_mode()` function.
    
    This makes the user experience more consistent, because the OpenSSL
    library is always queried and the `crypto.getFips()` always returns
    OpenSSL settings.
    
    Fixes nodejs#34903
    
    Backport-PR-URL: nodejs#40241
    PR-URL: nodejs#36341
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    voxik authored and danbev committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    2b35f7b View commit details
    Browse the repository at this point in the history
  2. squash! crypto: make FIPS related options always awailable

    I made a mistake when resolving the conflict in this test and this
    commmit fixes it.
    danbev committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    9f7f84c View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. squash! crypto: make FIPS related options always awailable

    This commit adds code that I missed when backporting.
    danbev committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    c59618a View commit details
    Browse the repository at this point in the history
  2. squash! crypto: make FIPS related options always awailable

    Fix lint issue.
    danbev committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    e942e28 View commit details
    Browse the repository at this point in the history