meta: add .mailmap entry for Jimbly #40267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate two email addresses for Jimbly into one AUTHORS record using .mailmap.
nodejs-github-bot
added
the
meta
|
@Jimbly I have to imagine both "Jimb Esser" entries are you, but nonetheless, if you could confirm that they aren't two different Jimb Essers, that would be great. |
Also, confirming that we're keeping the right email address here would also be great! |
jasnell
approved these changes
Sep 30, 2021
|
Yup, those are both me, and that's the appropriate address. |
Trott
added
fast-track
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
lpinca
approved these changes
Sep 30, 2021
Trott
added
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 8a58fce...b5cfb26 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 3, 2021
Consolidate two email addresses for Jimbly into one AUTHORS record using .mailmap. PR-URL: #40267 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
Consolidate two email addresses for Jimbly into one AUTHORS record using .mailmap. PR-URL: #40267 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate two email addresses for Jimbly into one AUTHORS record using
.mailmap.