Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove usage of AllocatedBuffer from stream_* #40293

Closed
wants to merge 1 commit into from
Closed

src: remove usage of AllocatedBuffer from stream_* #40293

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 3, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Oct 3, 2021
addaleax
addaleax approved these changes Oct 6, 2021
View reviewed changes
src/stream_base.cc Outdated Show resolved Hide resolved
src/stream_base.cc Outdated Show resolved Hide resolved
src/stream_base.cc Outdated Show resolved Hide resolved
src/stream_base.cc Outdated Show resolved Hide resolved
src/stream_base.cc Outdated Show resolved Hide resolved
src/stream_pipe.cc Outdated Show resolved Hide resolved
src/stream_base.cc Outdated Show resolved Hide resolved
@RaisinTen RaisinTen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 6, 2021
@RaisinTen
src: remove usage of AllocatedBuffer from stream_*
9ed6888 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen RaisinTen force-pushed the src/remove-usage-of-AllocatedBuffer-from-stream branch from d111e66 to 9ed6888 Compare October 8, 2021 15:56
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 9, 2021
Open
21 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40228/

This was referenced Oct 10, 2021
Open
Open
@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 11, 2021
@Mesteery
Copy link
Member

@RaisinTen The PR didn't land because the CI was running. I think you could remove the commit-queue label and put it back.

pr 40293 skipped, CI still running

https://github.com/nodejs/node/runs/3863311768?check_suite_focus=true#step:8:46

@targos
Copy link
Member

targos commented Oct 12, 2021

I think we'll have to land this one manually. Sometimes GitHub's API reports pending checks that don't exist.

RaisinTen added a commit that referenced this pull request Oct 12, 2021
@RaisinTen
src: remove usage of AllocatedBuffer from stream_*
a784258 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40293
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@RaisinTen
Copy link
Contributor Author

Landed in a784258

@RaisinTen RaisinTen closed this Oct 12, 2021
@RaisinTen RaisinTen deleted the src/remove-usage-of-AllocatedBuffer-from-stream branch October 12, 2021 05:58
@RaisinTen RaisinTen removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021
@github-actions github-actions bot mentioned this pull request Oct 13, 2021
Open
22 tasks
targos pushed a commit that referenced this pull request Oct 13, 2021
@RaisinTen @targos
src: remove usage of AllocatedBuffer from stream_*
faf9e28 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40293
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actions github-actions bot mentioned this pull request Oct 14, 2021
Open
22 tasks
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
This was referenced Oct 15, 2021
Open
Open
@richardlau richardlau mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@RaisinTen @nodejs-github-bot @Mesteery @targos @jasnell @addaleax