dgram: add nread assertion to UDPWrap::OnRecv
#40295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This asserts that the number of bytes received by the socket is less than or equal to the size allocated for the temporary storage. Signed-off-by: Darshan Sen <darshan.sen@postman.com>
nodejs-github-bot
added
c++
jasnell
approved these changes
Oct 3, 2021
RaisinTen
added
author ready
addaleax
approved these changes
Oct 6, 2021
JungMinu
approved these changes
Oct 8, 2021
RaisinTen
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 7723148...cca9b95 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
This asserts that the number of bytes received by the socket is less than or equal to the size allocated for the temporary storage. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
This asserts that the number of bytes received by the socket is less than or equal to the size allocated for the temporary storage. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This asserts that the number of bytes received by the socket is less
than or equal to the size allocated for the temporary storage.
Signed-off-by: Darshan Sen darshan.sen@postman.com