Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix the inline code-block at the NodeDhKeyGenParams class #40341

Closed
wants to merge 1 commit into from
Closed

doc: fix the inline code-block at the NodeDhKeyGenParams class #40341

wants to merge 1 commit into from

Conversation

J-Human
Copy link
Contributor

@J-Human J-Human commented Oct 6, 2021

Missing a back-tick here.

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Oct 6, 2021
@Lxxyx Lxxyx added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Fast-track has been requested by @Lxxyx. Please 👍 to approve.

@Ayase-252 Ayase-252 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 6, 2021
@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Landed in f1c196d...2ac95c6

@github-actions github-actions bot closed this Oct 6, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 6, 2021
@J-Human @nodejs-github-bot
doc: fix the inline code-block at the NodeDhKeyGenParams class
2ac95c6 
PR-URL: #40341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@J-Human J-Human deleted the doc/fix-typo-at-nodedhkeygenparams-class branch October 6, 2021 23:35
danielleadams pushed a commit that referenced this pull request Oct 7, 2021
@J-Human @danielleadams
doc: fix the inline code-block at the NodeDhKeyGenParams class
dc9c319 
PR-URL: #40341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@danielleadams danielleadams mentioned this pull request Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@Flarna Flarna Flarna approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@J-Human @Trott @benjamingr @Ayase-252 @Lxxyx @Flarna @nodejs-github-bot