Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: suppress zlib compiler warnings #40343

Closed
wants to merge 2 commits into from
Closed

Commits on Oct 11, 2021

  1. deps: suppress zlib compiler warnings

    Currently, there are a number of compilation warnings from zlib like the
    following one:
    
    ../deps/zlib/infback.c: In function ‘inflateBack’:
    ../deps/zlib/infback.c:479:25: warning:
    this statement may fall through [-Wimplicit-fallthrough=]
      479 |             state->mode = LEN;
          |             ~~~~~~~~~~~~^~~~~
    ../deps/zlib/infback.c:481:9: note: here
      481 |         case LEN:
          |         ^~~~
    
    In this case there is no break statement and the intention is to fall
    through:
    
               Tracev((stderr, "inflate:       codes ok\n"));
               state->mode = LEN;
    
            case LEN:
    
    This commit adds -Wno-implicit-fallthrough' to zlib.gyp to suppress
    these warnings.
    danbev committed Oct 11, 2021
    Copy the full SHA
    5a689b6 View commit details
    Browse the repository at this point in the history
  2. squash! deps: suppress zlib compiler warnings

    Move cflags into conditions section and only enable for non-windows
    architectures.
    danbev committed Oct 11, 2021
    Copy the full SHA
    9f53d9a View commit details
    Browse the repository at this point in the history