Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: throw error to object mode in Socket #40344

Closed
wants to merge 5 commits into from
Closed

net: throw error to object mode in Socket #40344

wants to merge 5 commits into from

Commits on Oct 7, 2021

  1. net: throw error to object mode in Socket 

    Fixes: nodejs#40336
    @watilde
    watilde committed Oct 7, 2021
    Copy the full SHA
    d47c4f4 View commit details
    Browse the repository at this point in the history

  2. net: check objectMode first and then readble || writable 

    Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
    @watilde @lpinca
    watilde and lpinca committed Oct 7, 2021
    Copy the full SHA
    144fef2 View commit details
    Browse the repository at this point in the history

  3. net: remove unused ObjectKeys 

    Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
    @watilde @lpinca
    watilde and lpinca committed Oct 7, 2021
    Copy the full SHA
    6047006 View commit details
    Browse the repository at this point in the history

  4. test: replace common port with specific number

    @watilde
    watilde committed Oct 7, 2021
    Copy the full SHA
    b9c41d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. net: check if option is undefined

    @watilde
    watilde committed Oct 8, 2021
    Copy the full SHA
    43ba42e View commit details
    Browse the repository at this point in the history