lib: refactor internal debug variable #40364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gdccwxx
commented
Oct 7, 2021
gdccwxx
commented
- refractor internal/debugger/inspect_client.js to use let.
- move variable into each for loop
nodejs-github-bot
added
debugger
jasnell
approved these changes
Oct 7, 2021
|
nit: The pull request title should start with |
Lxxyx
approved these changes
Oct 7, 2021
Lxxyx
added
request-ci
gdccwxx
changed the title
gdccwxx
changed the title
move variable into each for loop
gdccwxx
force-pushed
the
lib/refactor-internal-debug-variable
branch
from
2f6e1e1
to
604d0d4
Compare
github-actions
bot
removed
the
request-ci
Ayase-252
added
the
author ready
aduh95
added
the
commit-queue
aduh95
approved these changes
Oct 9, 2021
github-actions
bot
removed
the
commit-queue
|
Landed in eafdeab...ac4f5e2 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
move variable into each for loop PR-URL: #40364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
move variable into each for loop PR-URL: #40364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.