meta: use .mailmap to consolidate AUTHORS entries for ide #40367
Conversation
nodejs-github-bot
added
the
meta
|
@ide This removes your expo.io email from AUTHORS and leaves your jameside.com email there. (Currently both are in the file.) If you'd prefer it the other way around (leave expo.io and remove jameside.com) or a third email address to replace both entries, please leave a comment. Thanks! |
|
Could you please change the expo.io email to expo.dev? Thank you! |
Ultimately, what's the one email address you want to show up in AUTHORS? Is it this?: Or this?: |
|
Could you please use the jameside.com domain? Thank you! |
OK, cool, that's what this change does. (I can't change the expo.io to expo.dev because that's a .mailmap entry. If I change it, then it won't change your expo.io email in the git log to jameside.com and the expo.io entry will start showing up in AUTHORS again. What that entry says is "Wherever you see this expo.io email in the git log, treat it as this jameside.com email instead.") |
Trott
added
author ready
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
James Ide has two AUTHORS entries. Use .mailmap to consolidate them into a single entry. PR-URL: nodejs#40367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
|
Landed in 6a205d7 |
James Ide has two AUTHORS entries. Use .mailmap to consolidate them into a single entry. PR-URL: #40367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
James Ide has two AUTHORS entries. Use .mailmap to consolidate them into
a single entry.