Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] URL WPT changes #40383

Closed
wants to merge 11 commits into from
Closed

[v16.x backport] URL WPT changes #40383

wants to merge 11 commits into from

Commits on Oct 9, 2021

  1. doc: anchor link parity between markdown and html-generated docs 

    Main changes:

- Replace current HTML anchor generation to match
  header anchor generation in Github markdown.
- Remove unnecessary double namespacing on generated anchors/links (E.G.
  `esm.md#loaders` instead of `esm.md#esm_loaders`).
- Anchors/links are automatically prefixed with their respective modules
  when concatenated for usage in `all.html`.

Benefits:

- All anchor links within and between markdown API docs actually work.
- Adding new anchor links no longer requires contributors to generate
  the HTML docs first to look up the correct anchors.
- Anchors are much shorter.
- All previous anchor links are preserved by generating hidden legacy
  anchors.

PR-URL: nodejs#39304
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @foxxyz @targos
    foxxyz authored and targos committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    d3f3111 View commit details
    Browse the repository at this point in the history

  2. esm: consolidate ESM loader hooks 

    doc: update ESM hook examples

esm: fix unsafe primordial

doc: fix ESM example linting

esm: allow source of type ArrayBuffer

doc: update ESM hook changelog to include resolve format

esm: allow all ArrayBuffers and TypedArrays for load hook source

doc: tidy code & API docs

doc: convert ESM source table header from Title Case to Sentence case

doc: add detailed explanation for getPackageType

esm: add caveat that ESMLoader::import() must NOT be renamed

esm: tidy code declaration of getFormat protocolHandlers

doc: correct ESM doc link (bad conflict resolution)

doc: update ESM hook limitation for CJS

esm: tweak preload description

doc: update ESM getPackageType() example explanation

PR-URL: nodejs#37468
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    @JakobJingleheimer @targos
    JakobJingleheimer authored and targos committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    7bc0d7c View commit details
    Browse the repository at this point in the history

  3. v8: remove --harmony-top-level-await 

    PR-URL: nodejs#40226
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @GeoffreyBooth @targos
    GeoffreyBooth authored and targos committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    07ea5c6 View commit details
    Browse the repository at this point in the history

  4. crypto: remove incorrect constructor invocation 

    PR-URL: nodejs#40300
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    @gc @targos
    gc authored and targos committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    954df09 View commit details
    Browse the repository at this point in the history

  5. doc: deprecate (doc-only) http abort related 

    Refs: nodejs#36641
Refs: nodejs#36617 (comment)

Documentation-only deprecate `.aborted` property and `'abort'`,
`'aborted'` event in `http`, and suggest using the corresponding
Stream API instead.

Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Robert Nagy <ronagy@icloud.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#36670
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @dr-js @targos
    dr-js authored and targos committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    4da1318 View commit details
    Browse the repository at this point in the history

  6. doc: assign missing deprecation number 

    Refs: nodejs#36670

PR-URL: nodejs#40324
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    @targos
    targos committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    a5a3a93 View commit details
    Browse the repository at this point in the history

  7. doc: fix typo in ESM example 

    Refs: nodejs#37468

PR-URL: nodejs#40275
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @tniessen @targos
    tniessen authored and targos committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    f0ecb6e View commit details
    Browse the repository at this point in the history

  8. doc: fix typo in esm.md 

    _subpath_ is not defined in this context. This is pretty clearly meant
to be _packageSubpath_, which is the second argument to
`PACKAGE_SELF_RESOLVE`

PR-URL: nodejs#40273
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @MasonM @targos
    MasonM authored and targos committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    daa61b4 View commit details
    Browse the repository at this point in the history

  9. doc: correct ESM load hook table header 

    `resolve` does not return a `source` property

PR-URL: nodejs#40234
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @JakobJingleheimer @targos
    JakobJingleheimer authored and targos committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    cef6838 View commit details
    Browse the repository at this point in the history

  10. lib,url: correct URL's argument to pass idlharness 

    `url.idl` defines URL's constructor as:

```
constructor(USVString url, optional USVString base);
```

`idlharness.any.js` checks its length as `1`. So we should remove
constructor's second argument and use `arguments[1]` in constructor's
logic.

Refs: https://url.spec.whatwg.org/#idl-index

PR-URL: nodejs#39848
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @XadillaX @targos
    XadillaX authored and targos committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    bf377f2 View commit details
    Browse the repository at this point in the history

  11. test: pass URL's toascii.window.js WPT 

    PR-URL: nodejs#39910
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    @XadillaX @targos
    XadillaX authored and targos committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    1310399 View commit details
    Browse the repository at this point in the history