Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: consolidate AUTHORS entry for thw0rted #40387

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 9, 2021

Use a .mailmap entry to consolidate the two entries for thw0rted in
AUTHORS into one entry.

Use a .mailmap entry to consolidate the two entries for thw0rted in
AUTHORS into one entry.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 9, 2021
@Trott
Copy link
Member Author

Trott commented Oct 9, 2021

@thw0rted This removes the users.noreply.github.com email from our AUTHORS file and leaves the gdit.com address. If you would prefer we do it the other way around, please leave a comment. Thanks!

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

Fast-track has been requested by @Trott. Please 👍 to approve.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

Landed in ac4f5e2...a3c0713

@github-actions github-actions bot closed this Oct 9, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 9, 2021
Use a .mailmap entry to consolidate the two entries for thw0rted in
AUTHORS into one entry.

PR-URL: #40387
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott deleted the authors-jb branch October 9, 2021 19:35
targos pushed a commit that referenced this pull request Oct 13, 2021
Use a .mailmap entry to consolidate the two entries for thw0rted in
AUTHORS into one entry.

PR-URL: #40387
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants