Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: format changelogs #40388

Closed
wants to merge 1 commit into from
Closed

doc: format changelogs #40388

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 9, 2021

Use the format-md task to format changelogs.

Use the format-md task to format changelogs.
@nodejs-github-bot nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Oct 9, 2021
@targos
Copy link
Member

targos commented Oct 9, 2021

image

This would have to be fixed in changelog-maker

@Trott
Copy link
Member Author

Trott commented Oct 9, 2021

image

This would have to be fixed in changelog-maker

Ooh, I guess we could in theory incorporate the formatter into changelog-maker without too much difficulty. I'll look into that.

Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 9, 2021
Trott added a commit to Trott/changelog-maker that referenced this pull request Oct 9, 2021
Trott added a commit to Trott/changelog-maker that referenced this pull request Oct 10, 2021
targos pushed a commit to nodejs/changelog-maker that referenced this pull request Oct 10, 2021
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2021
@github-actions
Copy link
Contributor

Landed in 4f68839...40db88b

@github-actions github-actions bot closed this Oct 11, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 11, 2021
Use the format-md task to format changelogs.

PR-URL: #40388
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
Use the format-md task to format changelogs.

PR-URL: #40388
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
github-actions bot pushed a commit to nodejs/changelog-maker that referenced this pull request Oct 14, 2021
## [2.7.0](v2.6.0...v2.7.0) (2021-10-14)

### Features

* run Node.js markdown formatter on markdown output ([#98](#98)) ([26afb81](26afb81))

### Bug Fixes

* main instead of master ([c6aac22](c6aac22))
* remove build step from release process ([ec2b9c0](ec2b9c0))

### Trivial Changes

* add auto-release workflow ([36ca9e5](36ca9e5))
* add dependabot config ([5f16f7e](5f16f7e))
* **deps:** bump remark-preset-lint-node from 3.2.0 to 3.3.0 ([ed6ff3b](ed6ff3b))
* **deps:** bump remark-stringify from 10.0.0 to 10.0.1 ([73c2046](73c2046))
* escape opening bracket explicitly ([#97](#97)) ([64c1220](64c1220)), closes [/github.com/nodejs/node/pull/40388#issuecomment-939321694](https://github.com/nodejs//github.com/nodejs/node/pull/40388/issues/issuecomment-939321694)
* update package-lock.json ([#102](#102)) ([24112e0](24112e0))
* update standard (and path-parse) ([#96](#96)) ([66b6eef](66b6eef))
* update test workflow ([#100](#100)) ([eaeb938](eaeb938))
@richardlau richardlau mentioned this pull request Oct 18, 2021
@Trott Trott deleted the format-changelogs branch September 25, 2022 17:10
renawolford6 added a commit to renawolford6/changelog-maker-javascript that referenced this pull request Nov 9, 2022
renawolford6 added a commit to renawolford6/changelog-maker-javascript that referenced this pull request Nov 9, 2022
## [2.7.0](nodejs/changelog-maker@v2.6.0...v2.7.0) (2021-10-14)

### Features

* run Node.js markdown formatter on markdown output ([#98](nodejs/changelog-maker#98)) ([26afb81](nodejs/changelog-maker@26afb81))

### Bug Fixes

* main instead of master ([c6aac22](nodejs/changelog-maker@c6aac22))
* remove build step from release process ([ec2b9c0](nodejs/changelog-maker@ec2b9c0))

### Trivial Changes

* add auto-release workflow ([36ca9e5](nodejs/changelog-maker@36ca9e5))
* add dependabot config ([5f16f7e](nodejs/changelog-maker@5f16f7e))
* **deps:** bump remark-preset-lint-node from 3.2.0 to 3.3.0 ([ed6ff3b](nodejs/changelog-maker@ed6ff3b))
* **deps:** bump remark-stringify from 10.0.0 to 10.0.1 ([73c2046](nodejs/changelog-maker@73c2046))
* escape opening bracket explicitly ([#97](nodejs/changelog-maker#97)) ([64c1220](nodejs/changelog-maker@64c1220)), closes [/github.com/nodejs/node/pull/40388#issuecomment-939321694](https://github.com/nodejs//github.com/nodejs/node/pull/40388/issues/issuecomment-939321694)
* update package-lock.json ([#102](nodejs/changelog-maker#102)) ([24112e0](nodejs/changelog-maker@24112e0))
* update standard (and path-parse) ([#96](nodejs/changelog-maker#96)) ([66b6eef](nodejs/changelog-maker@66b6eef))
* update test workflow ([#100](nodejs/changelog-maker#100)) ([eaeb938](nodejs/changelog-maker@eaeb938))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants