doc: fix missing variable in deepStrictEqual example #40396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Oct 10, 2021
nodejs-github-bot
added
assert
targos
approved these changes
Oct 10, 2021
Mesteery
added
the
author ready
benjamingr
approved these changes
Oct 10, 2021
cjihrig
approved these changes
Oct 10, 2021
RaisinTen
approved these changes
Oct 11, 2021
DerekNonGeneric
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
@olivierodo, thanks for the PR. If you could rebase to make this into a single commit that included a commit message that adhered to our commit message guidelines, we can get this landed straight-away.
olivierodo
force-pushed
the
olivierodo-doc-deepStrictEqual
branch
from
38bb9f5
to
c14e700
Compare
Lxxyx
approved these changes
Oct 11, 2021
DerekNonGeneric
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/40396 ✔ Done loading data for nodejs/node/pull/40396 ----------------------------------- PR info ------------------------------------ Title doc: fix missing variable in deepStrictEqual example (#40396) Author OliverOdo (@olivierodo, first-time contributor) Branch olivierodo:olivierodo-doc-deepStrictEqual -> nodejs:master Labels assert, doc, author ready Commits 1 - doc: fix missing variable in deepStrictEqual example Committers 1 - Olivier PR-URL: https://github.com/nodejs/node/pull/40396 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Benjamin Gruenbaum Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: Derek Lewis Reviewed-By: Zijian Liu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40396 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Benjamin Gruenbaum Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: Derek Lewis Reviewed-By: Zijian Liu -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 10 Oct 2021 02:02:39 GMT ✔ Approvals: 8 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40396#pullrequestreview-775621745 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40396#pullrequestreview-775637718 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/40396#pullrequestreview-775683493 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40396#pullrequestreview-775684832 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40396#pullrequestreview-775693846 ✔ - Darshan Sen (@RaisinTen): https://github.com/nodejs/node/pull/40396#pullrequestreview-775819978 ✔ - Derek Lewis (@DerekNonGeneric): https://github.com/nodejs/node/pull/40396#pullrequestreview-775829471 ✔ - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/40396#pullrequestreview-775912578 ✖ This PR needs to wait 16 more hours to land ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1328284967 |
github-actions
bot
added
the
commit-queue-failed
DerekNonGeneric
added
the
fast-track
|
Fast-track has been requested by @DerekNonGeneric. Please 👍 to approve. |
DerekNonGeneric
added
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 5d7bd86...4f68839 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 11, 2021
PR-URL: #40396 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
PR-URL: #40396 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.