meta: consolidate AUTHORS information for geirha #40406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a .mailmap entry to consolidate the two entries for gierha in AUTHORS into a single entry.
nodejs-github-bot
added
the
meta
|
@gierha This change removes your ntnu.no email address from the AUTHORS file and leaves your gmail.com address. If you'd prefer we do it the other way around, please comment. Thanks! |
|
@geirha ^ |
tniessen
approved these changes
Oct 11, 2021
aduh95
approved these changes
Oct 11, 2021
|
@Trott That is fine; keep gmail, remove ntnu. |
Mesteery
added
the
author ready
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Lxxyx
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 73c3885...a941189 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 12, 2021
Use a .mailmap entry to consolidate the two entries for gierha in AUTHORS into a single entry. PR-URL: #40406 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
Use a .mailmap entry to consolidate the two entries for gierha in AUTHORS into a single entry. PR-URL: #40406 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a .mailmap entry to consolidate the two entries for gierha in
AUTHORS into a single entry.