Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove ESLint disable comments which were breaking the CJS/ESM code block toggles #40408

Closed
wants to merge 1 commit into from

Conversation

mskelton
Copy link
Contributor

Some of the code blocks for the assert docs were not properly showing the CJS/ESM toggle which was due to some unnecessary ESLint disable comments. Removing these comments fixed the issue so the code blocks once again work as expected.

See the current docs for an example of the currently broken behavior: https://nodejs.org/docs/latest-v16.x/api/assert.html#assert_assert_doesnotreject_asyncfn_error_message

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Oct 11, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2021
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 12, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021
@github-actions
Copy link
Contributor

Landed in 54a85d6...15ce81a

@github-actions github-actions bot closed this Oct 12, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 12, 2021
PR-URL: #40408
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
PR-URL: #40408
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@richardlau richardlau mentioned this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants