Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: consolidate AUTHORS entries for gabrielschulhof #40420

Closed
wants to merge 1 commit into from
Closed

meta: consolidate AUTHORS entries for gabrielschulhof #40420

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 12, 2021

No description provided.

@Trott
Copy link
Member Author

Trott commented Oct 12, 2021

@gabrielschulhof

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 12, 2021
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 12, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 12, 2021
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021
@github-actions
Copy link
Contributor

Landed in 9fcc84d...c350c21

@github-actions github-actions bot closed this Oct 12, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 12, 2021
@Trott @nodejs-github-bot
meta: consolidate AUTHORS entries for gabrielschulhof
c350c21 
PR-URL: #40420
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Oct 13, 2021
@Trott @targos
meta: consolidate AUTHORS entries for gabrielschulhof
bcd59d7 
PR-URL: #40420
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
@richardlau richardlau mentioned this pull request Oct 18, 2021
Merged
@Trott Trott deleted the authors-gs branch October 19, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@tniessen tniessen tniessen approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Trott @lpinca @targos @tniessen @Lxxyx @nodejs-github-bot