meta: consolidate AUTHORS entries for ebickle #40447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
|
@ebickle This PR removes your users.noreply.github.com from the AUTHORS file in favor of your outlook.com email address. (Currently, there is an entry for each email address.) If you want to do it the other way around, please me know. Thanks! |
|
Looks good to me, thank you! @Trott If my noreply address isn't needed for correlating to commits, you're welcome to just leave the @outlook.com one if its preferable. |
|
Fast-track has been requested by @Mesteery. Please 👍 to approve. |
Lxxyx
approved these changes
Oct 14, 2021
Mesteery
added
the
author ready
lpinca
approved these changes
Oct 14, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in a278117...881174e |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
PR-URL: #40447 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2 tasks
targos
pushed a commit
that referenced
this pull request
Nov 4, 2021
PR-URL: #40447 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.