Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.12.0 proposal #40504

Merged
merged 60 commits into from Oct 20, 2021
Merged

v16.12.0 proposal #40504

merged 60 commits into from Oct 20, 2021

Commits on Oct 12, 2021

  1. doc: anchor link parity between markdown and html-generated docs

    Main changes:
    
    - Replace current HTML anchor generation to match
      header anchor generation in Github markdown.
    - Remove unnecessary double namespacing on generated anchors/links (E.G.
      `esm.md#loaders` instead of `esm.md#esm_loaders`).
    - Anchors/links are automatically prefixed with their respective modules
      when concatenated for usage in `all.html`.
    
    Benefits:
    
    - All anchor links within and between markdown API docs actually work.
    - Adding new anchor links no longer requires contributors to generate
      the HTML docs first to look up the correct anchors.
    - Anchors are much shorter.
    - All previous anchor links are preserved by generating hidden legacy
      anchors.
    
    PR-URL: #39304
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    foxxyz authored and danielleadams committed Oct 12, 2021
    Copy the full SHA
    1ef2cf8 View commit details
    Browse the repository at this point in the history
  2. esm: consolidate ESM loader hooks

    doc: update ESM hook examples
    
    esm: fix unsafe primordial
    
    doc: fix ESM example linting
    
    esm: allow source of type ArrayBuffer
    
    doc: update ESM hook changelog to include resolve format
    
    esm: allow all ArrayBuffers and TypedArrays for load hook source
    
    doc: tidy code & API docs
    
    doc: convert ESM source table header from Title Case to Sentence case
    
    doc: add detailed explanation for getPackageType
    
    esm: add caveat that ESMLoader::import() must NOT be renamed
    
    esm: tidy code declaration of getFormat protocolHandlers
    
    doc: correct ESM doc link (bad conflict resolution)
    
    doc: update ESM hook limitation for CJS
    
    esm: tweak preload description
    
    doc: update ESM getPackageType() example explanation
    
    PR-URL: #37468
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    JakobJingleheimer authored and danielleadams committed Oct 12, 2021
    Copy the full SHA
    3743406 View commit details
    Browse the repository at this point in the history
  3. v8: remove --harmony-top-level-await

    PR-URL: #40226
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    GeoffreyBooth authored and danielleadams committed Oct 12, 2021
    Copy the full SHA
    5f3f3a5 View commit details
    Browse the repository at this point in the history
  4. crypto: remove incorrect constructor invocation

    PR-URL: #40300
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    gc authored and danielleadams committed Oct 12, 2021
    Copy the full SHA
    a8926d1 View commit details
    Browse the repository at this point in the history
  5. doc: deprecate (doc-only) http abort related

    Refs: #36641
    Refs: #36617 (comment)
    
    Documentation-only deprecate `.aborted` property and `'abort'`,
    `'aborted'` event in `http`, and suggest using the corresponding
    Stream API instead.
    
    Co-authored-by: Michaël Zasso <targos@protonmail.com>
    Co-authored-by: Rich Trott <rtrott@gmail.com>
    Co-authored-by: Robert Nagy <ronagy@icloud.com>
    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    
    PR-URL: #36670
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    dr-js authored and danielleadams committed Oct 12, 2021
    Copy the full SHA
    d1d9f2d View commit details
    Browse the repository at this point in the history
  6. doc: assign missing deprecation number

    Refs: #36670
    
    PR-URL: #40324
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    targos authored and danielleadams committed Oct 12, 2021
    Copy the full SHA
    f848553 View commit details
    Browse the repository at this point in the history
  7. doc: fix typo in ESM example

    Refs: #37468
    
    PR-URL: #40275
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and danielleadams committed Oct 12, 2021
    Copy the full SHA
    3b3aaa0 View commit details
    Browse the repository at this point in the history
  8. doc: fix typo in esm.md

    _subpath_ is not defined in this context. This is pretty clearly meant
    to be _packageSubpath_, which is the second argument to
    `PACKAGE_SELF_RESOLVE`
    
    PR-URL: #40273
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MasonM authored and danielleadams committed Oct 12, 2021
    Copy the full SHA
    5b074af View commit details
    Browse the repository at this point in the history
  9. doc: correct ESM load hook table header

    `resolve` does not return a `source` property
    
    PR-URL: #40234
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    JakobJingleheimer authored and danielleadams committed Oct 12, 2021
    Copy the full SHA
    71a94aa View commit details
    Browse the repository at this point in the history
  10. dns: refactor and use validators

    The logical NOT operator and validators should be used where
    appropriate.
    
    PR-URL: #40022
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    VoltrexKeyva authored and danielleadams committed Oct 12, 2021
    Copy the full SHA
    2d409ed View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. vm: add support for import assertions in dynamic imports

    PR-URL: #40249
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    aduh95 authored and targos committed Oct 13, 2021
    Copy the full SHA
    4116b6c View commit details
    Browse the repository at this point in the history
  2. doc: add link to core promises tracking issue

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #40355
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    mhdawson authored and targos committed Oct 13, 2021
    Copy the full SHA
    38d8138 View commit details
    Browse the repository at this point in the history
  3. dgram: add nread assertion to UDPWrap::OnRecv

    This asserts that the number of bytes received by the socket is less
    than or equal to the size allocated for the temporary storage.
    
    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40295
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    RaisinTen authored and targos committed Oct 13, 2021
    Copy the full SHA
    7e02124 View commit details
    Browse the repository at this point in the history
  4. doc: improve phrasing in fs.md

    PR-URL: #40255
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    warlock1996 authored and targos committed Oct 13, 2021
    Copy the full SHA
    6c091c7 View commit details
    Browse the repository at this point in the history
  5. tools: warn about duplicates when generating AUTHORS file

    PR-URL: #40304
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    c3a744f View commit details
    Browse the repository at this point in the history
  6. meta: use .mailmap to consolidate AUTHORS entries for ide

    James Ide has two AUTHORS entries. Use .mailmap to consolidate them into
    a single entry.
    
    PR-URL: #40367
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    5668182 View commit details
    Browse the repository at this point in the history
  7. doc: format doc/guides using format-md task

    PR-URL: #40358
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    fb7afb9 View commit details
    Browse the repository at this point in the history
  8. test: improve test coverage of fs.ReadStream with FileHandle

    PR-URL: #40018
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    aduh95 authored and targos committed Oct 13, 2021
    Copy the full SHA
    13d6a56 View commit details
    Browse the repository at this point in the history
  9. meta: update label-pr-config

    PR-URL: #40199
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Mesteery authored and targos committed Oct 13, 2021
    Copy the full SHA
    7f50313 View commit details
    Browse the repository at this point in the history
  10. test: fix "test/common/debugger" identify async function

    PR-URL: #40348
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    gdccwxx authored and targos committed Oct 13, 2021
    Copy the full SHA
    d8a36ee View commit details
    Browse the repository at this point in the history
  11. test: replace .then chains with await

    PR-URL: #40348
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    gdccwxx authored and targos committed Oct 13, 2021
    Copy the full SHA
    07dae7f View commit details
    Browse the repository at this point in the history
  12. test: add test for readStream.path when fd is specified

    Refs: #40252 (review)
    
    PR-URL: #40359
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Ayase-252 authored and targos committed Oct 13, 2021
    Copy the full SHA
    641b1bb View commit details
    Browse the repository at this point in the history
  13. lib: refactor to use let

    move variable into each for loop
    
    PR-URL: #40364
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    gdccwxx authored and targos committed Oct 13, 2021
    Copy the full SHA
    168020e View commit details
    Browse the repository at this point in the history
  14. meta: consolidate AUTHORS entry for thw0rted

    Use a .mailmap entry to consolidate the two entries for thw0rted in
    AUTHORS into one entry.
    
    PR-URL: #40387
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    1224817 View commit details
    Browse the repository at this point in the history
  15. build: make scripts in gyp run with right python

    PR-URL: #39730
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    zcbenz authored and targos committed Oct 13, 2021
    Copy the full SHA
    2de57ed View commit details
    Browse the repository at this point in the history
  16. test: fix typos in whatwg-webstreams explanations

    PR-URL: #40389
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and targos committed Oct 13, 2021
    Copy the full SHA
    6f6b99c View commit details
    Browse the repository at this point in the history
  17. typings: fix declaration of primordials

    PR-URL: #40222
    Fixes: #40144
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    targos committed Oct 13, 2021
    Copy the full SHA
    65b51d0 View commit details
    Browse the repository at this point in the history
  18. typings: define types for timers binding

    PR-URL: #40222
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    targos committed Oct 13, 2021
    Copy the full SHA
    c3a7a0b View commit details
    Browse the repository at this point in the history
  19. typings: add missing types to options and util bindings

    PR-URL: #40222
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    targos committed Oct 13, 2021
    Copy the full SHA
    ca9a854 View commit details
    Browse the repository at this point in the history
  20. typings: define types for os binding

    PR-URL: #40222
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    targos committed Oct 13, 2021
    Copy the full SHA
    7733b5e View commit details
    Browse the repository at this point in the history
  21. doc: fix typos in n-api docs

    PR-URL: #40402
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    igncp authored and targos committed Oct 13, 2021
    Copy the full SHA
    93a48e0 View commit details
    Browse the repository at this point in the history
  22. meta: update AUTHORS

    PR-URL: #40392
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and targos committed Oct 13, 2021
    Copy the full SHA
    fff3135 View commit details
    Browse the repository at this point in the history
  23. meta: consolidate duplicate AUTHORS entries for hassaanp

    Create a .mailmap entry to consolidate the two AUTHORS entries for
    hassaanp into a single entry.
    
    PR-URL: #40391
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    93cecb4 View commit details
    Browse the repository at this point in the history
  24. doc: fix asyncLocalStorage.run() description

    The description that store is not available
    when asynchronous operation is created within
    the callback is not accurate
    
    PR-URL: #40381
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    elegantcoder authored and targos committed Oct 13, 2021
    Copy the full SHA
    6f77d1a View commit details
    Browse the repository at this point in the history
  25. src: add missing initialization

    This missing initialization was reported by the coverity scans
    we are in the process of re-enabling.
    
    PR-URL: #40370
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    mhdawson authored and targos committed Oct 13, 2021
    Copy the full SHA
    857af2b View commit details
    Browse the repository at this point in the history
  26. deps: upgrade Corepack to 0.10

    PR-URL: #40374
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    arcanis authored and targos committed Oct 13, 2021
    Copy the full SHA
    91c3bf6 View commit details
    Browse the repository at this point in the history
  27. deps: suppress zlib compiler warnings

    Currently, there are a number of compilation warnings from zlib like the
    following one:
    
    ../deps/zlib/infback.c: In function ‘inflateBack’:
    ../deps/zlib/infback.c:479:25: warning:
    this statement may fall through [-Wimplicit-fallthrough=]
      479 |             state->mode = LEN;
          |             ~~~~~~~~~~~~^~~~~
    ../deps/zlib/infback.c:481:9: note: here
      481 |         case LEN:
          |         ^~~~
    
    In this case there is no break statement and the intention is to fall
    through:
    
               Tracev((stderr, "inflate:       codes ok\n"));
               state->mode = LEN;
    
            case LEN:
    
    This commit adds -Wno-implicit-fallthrough' to zlib.gyp to suppress
    these warnings.
    
    PR-URL: #40343
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    danbev authored and targos committed Oct 13, 2021
    Copy the full SHA
    dca5ac1 View commit details
    Browse the repository at this point in the history
  28. doc: fix missing variable in deepStrictEqual example

    PR-URL: #40396
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    olivierodo authored and targos committed Oct 13, 2021
    Copy the full SHA
    5eb9402 View commit details
    Browse the repository at this point in the history
  29. doc: format changelogs

    Use the format-md task to format changelogs.
    
    PR-URL: #40388
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    1d5857c View commit details
    Browse the repository at this point in the history
  30. tools: fix ESLint update scripts

    Changes to the npm dependency in the core repo require changes to
    update-eslint.sh and update-bable-eslint.sh.
    
    PR-URL: #40394
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    282b6eb View commit details
    Browse the repository at this point in the history
  31. tools: prepare ESLint rules for 8.0.0 requirements

    PR-URL: #40394
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    43b97c7 View commit details
    Browse the repository at this point in the history
  32. tools: update ESLint to 8.0.0

    PR-URL: #40394
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    d9157aa View commit details
    Browse the repository at this point in the history
  33. tools: remove @babel/plugin-syntax-top-level-await

    ESLint 8.0.0 introduced support for top level await, so
    @babel/plugin-syntax-top-level-await is no longer necessary.
    
    PR-URL: #40394
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    d6a99b7 View commit details
    Browse the repository at this point in the history
  34. tools: remove @bable/plugin-syntax-class-properties

    ESLint 8.0.0 makes the plugin unnecessary.
    
    PR-URL: #40394
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    b72d693 View commit details
    Browse the repository at this point in the history
  35. tools: remove @babel/plugin-syntax-import-assertions

    As of ESLint 8.0.0 at least, this plugin is unnecessary.
    
    PR-URL: #40394
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    3611073 View commit details
    Browse the repository at this point in the history
  36. tools: udpate @babel/eslint-parser

    Remove unused plugins and update @babel/eslint-parser
    
    PR-URL: #40394
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    50f91ab View commit details
    Browse the repository at this point in the history
  37. build: remove duplicate check for authors.yml

    update-authors.js will print if there are duplicates in the new entries
    so we can remove the (not working) duplication check in the authors.yml
    file. It would still be nice to get the information about duplicates
    into the body of the GitHub PR so no one has to manually check for
    duplicates (by either examining the file or looking at the Actions
    output), but that can be a future improvement.
    
    PR-URL: #40393
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    8bb3951 View commit details
    Browse the repository at this point in the history
  38. meta: consolidate AUTHORS information for geirha

    Use a .mailmap entry to consolidate the two entries for gierha in
    AUTHORS into a single entry.
    
    PR-URL: #40406
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    80b4245 View commit details
    Browse the repository at this point in the history
  39. doc: add pronouns for tniessen to README

    PR-URL: #40412
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and targos committed Oct 13, 2021
    Copy the full SHA
    85b7385 View commit details
    Browse the repository at this point in the history
  40. doc: remove ESLint comments which were breaking the CJS/ESM toggles

    PR-URL: #40408
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Mark Skelton authored and targos committed Oct 13, 2021
    Copy the full SHA
    dc7291d View commit details
    Browse the repository at this point in the history
  41. src: remove usage of AllocatedBuffer from stream_*

    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40293
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RaisinTen authored and targos committed Oct 13, 2021
    Copy the full SHA
    faf9e28 View commit details
    Browse the repository at this point in the history
  42. meta: consolidate AUTHORS entries for gabrielschulhof

    PR-URL: #40420
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott authored and targos committed Oct 13, 2021
    Copy the full SHA
    bcd59d7 View commit details
    Browse the repository at this point in the history
  43. net: throw error to object mode in Socket

    Fixes: #40336
    
    PR-URL: #40344
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    watilde authored and targos committed Oct 13, 2021
    Copy the full SHA
    a672be5 View commit details
    Browse the repository at this point in the history
  44. net: check objectMode first and then readble || writable

    Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
    
    PR-URL: #40344
    Fixes: #40336
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    watilde authored and targos committed Oct 13, 2021
    Copy the full SHA
    dbb2e6f View commit details
    Browse the repository at this point in the history
  45. net: remove unused ObjectKeys

    Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
    
    PR-URL: #40344
    Fixes: #40336
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    watilde authored and targos committed Oct 13, 2021
    Copy the full SHA
    4564a93 View commit details
    Browse the repository at this point in the history
  46. test: replace common port with specific number

    PR-URL: #40344
    Fixes: #40336
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    watilde authored and targos committed Oct 13, 2021
    Copy the full SHA
    1e15137 View commit details
    Browse the repository at this point in the history
  47. net: check if option is undefined

    PR-URL: #40344
    Fixes: #40336
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    watilde authored and targos committed Oct 13, 2021
    Copy the full SHA
    bc86084 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. deps: upgrade npm to 8.1.0

    PR-URL: #40463
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    npm-robot authored and richardlau committed Oct 18, 2021
    Copy the full SHA
    8fdabcb View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. stream: fix fromAsyncGen

    Fixes: #40497
    
    PR-URL: #40499
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    ronag authored and richardlau committed Oct 19, 2021
    Copy the full SHA
    2bfa87e View commit details
    Browse the repository at this point in the history
  2. 2021-10-20, Version 16.12.0 (Current)

    Notable Changes:
    
    Experimental ESM Loader Hooks API:
    
    Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining:
    1. `resolve`: `resolve` [+ `getFormat`]
    2. `load`: `getFormat` + `getSource` + `transformSource`
    
    For consistency, `getGlobalPreloadCode` has been renamed to `globalPreload`.
    
    A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks.
    
    Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468
    
    Other Notable Changes:
    
    deps:
      * upgrade npm to 8.1.0 (npm team) #40463
    doc:
      * deprecate (doc-only) http abort related (dr-js) #36670
    vm:
      * (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249
    
    PR-URL: #40504
    richardlau committed Oct 19, 2021
    Copy the full SHA
    4941550 View commit details
    Browse the repository at this point in the history