Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adds note about weak reference #40519

Closed
wants to merge 1 commit into from
Closed

Conversation

flovilmart
Copy link

As the channels are weakly held, if the consumer does not keep a reference to the channel, it may be de-allocated before an emitter fires.

As the channels are weakly held, if the consumer does not keep a reference to the channel, it may be de-allocated before an emitter fires.
@nodejs-github-bot nodejs-github-bot added diagnostics_channel Issues and PRs related to diagnostics channel doc Issues and PRs related to the documentations. labels Oct 19, 2021
@flovilmart flovilmart changed the title DiagnosticChannels: add not for weak reference doc: adds note about weak reference Oct 20, 2021
@legendecas
Copy link
Member

Related: #42170

The issue has been fixed by #44943 since the channels increase ref counting when there are active subscribers in that PR.

@legendecas
Copy link
Member

I am closing this PR. Please feel free to re-open if there is anything to discuss. Thank you for your contribution!

@legendecas legendecas closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostics_channel Issues and PRs related to diagnostics channel doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants