Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update onboarding task #40570

Closed
wants to merge 2 commits into from
Closed

doc: update onboarding task #40570

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b91ea
doc: update onboarding task
Trott Oct 22, 2021
f278216
fixup! doc: update onboarding task
Trott Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion onboarding.md
View file
Open in desktop
Expand Up @@ -215,7 +215,9 @@ needs to be pointed out separately during the onboarding.
labels. The `fast-track` label should cause the Node.js GitHub bot to post a
comment in the pull request asking collaborators to approve the pull request
by leaving a 👍 reaction on the comment.
* Run CI on the pull request. Use the `node-test-pull-request` CI task.
* Optional: Run CI on the pull request. Use the `node-test-pull-request` CI
task. As a convenience, you may apply the `request-ci` label to the pull
request to have a GitHub Actions workflow start the Jenkins CI task for you.
Comment on lines +219 to +220
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request-ci has no time guarentee, I don't think it would be very convenient for an onboarding session. Maybe that doesn't matter since it's optional anyway, but I wanted to point it out in case you didn't think of it.

* After two Collaborator approvals for the change and two Collaborator approvals
for fast-tracking, land the PR.
* If there are not enough approvals within a reasonable time, consider the
Expand Down