Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 8.1.3 #40726

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 8.1.3 #40726

wants to merge 1 commit into from

Conversation

npm-robot
Copy link
Contributor

v8.1.3 (2021-11-04)

BUG FIXES

DEPENDENCIES

  • ac2fabb86 #3990 @npmcli/arborist@4.0.4
    • fix: don't compare spec for local dep vs existing
    • fix: stop pruning peerSets when entryEdge is from a workspace
  • a0d35ff20 #3996 @npmcli/config@2.3.1:
    • fix: dont load project configs in global mode

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Nov 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@wraithgar
Copy link

An explanation for the size of the diff: there was a refactoring of some of the internals of the npm commands that resulted in a lot of churn for both the tests and the files.

BridgeAR
BridgeAR approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

MylesBorins
MylesBorins approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Nov 6, 2021
Open
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 8, 2021
Open
46 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@joyeecheung joyeecheung mentioned this pull request Nov 8, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40771/

@github-actions github-actions bot mentioned this pull request Nov 9, 2021
Open
23 tasks
@Trott
Copy link
Member

Trott commented Nov 9, 2021

Can someone at @nodejs/npm rebase against master and force push to the PR branch? test-policy-integrity will continue to fail on Windows until that happens. Sorry/thanks!

@github-actions github-actions bot mentioned this pull request Nov 10, 2021
Open
26 tasks
@wraithgar
Copy link

Done, thanks for the heads up. Our fork got a little behind there, it's up to date now.

@Trott Trott mentioned this pull request Nov 10, 2021
Closed
Trott added a commit to Trott/io.js that referenced this pull request Nov 10, 2021
@Trott
doc: format fix for crypto.md
dcf88ac 
A somewhat old PR landed and it fails current linting. This is the fix.

Ref: nodejs#40726
@Trott
Copy link
Member

Trott commented Nov 10, 2021

Done, thanks for the heads up. Our fork got a little behind there, it's up to date now.

Argh...sorry, you'll need to do it one more time once #40781 lands. (Collaborators, please review and fast-track that. Thanks.)

@wraithgar
Copy link

Ok I'm watching #40780 and will rebase our fork once that lands

@Trott
Copy link
Member

Trott commented Nov 10, 2021

Sorry to do this to you, but a lint fix just landed. Can you rebase one more time?

@wraithgar
Copy link

Sorry to do this to you, but a lint fix just landed. Can you rebase one more time?

Done. this is really no problem at all, glad to help.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40823/

@github-actions github-actions bot mentioned this pull request Nov 11, 2021
Open
31 tasks
@Trott
Copy link
Member

Trott commented Nov 11, 2021

Landed in 6e16297

@Trott Trott closed this Nov 11, 2021
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 11, 2021
@npm-robot @Trott
deps: upgrade npm to 8.1.3
6e16297 
PR-URL: nodejs#40726
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Nov 12, 2021
Open
Open
targos pushed a commit that referenced this pull request Nov 21, 2021
@npm-robot @targos
deps: upgrade npm to 8.1.3
9711ccf 
PR-URL: #40726
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@npm-robot @danielleadams
deps: upgrade npm to 8.1.3
682f200 
PR-URL: #40726
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@npm-robot @danielleadams
deps: upgrade npm to 8.1.3
c0200e2 
PR-URL: #40726
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet