Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix length option being ignored during read() #40906

Merged
merged 3 commits into from Dec 10, 2021
Merged

fs: fix length option being ignored during read() #40906

merged 3 commits into from Dec 10, 2021

Commits on Nov 21, 2021

  1. fs: fix length option being ignored during read() 

    Currently, `length` in an options object is ignored.
    @fracsinus
    fracsinus committed Nov 21, 2021
    Copy the full SHA
    4948c56 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. fs: use nullish coalescing to respect zero-length reads 

    Co-authored-by: Robert Nagy <ronagy@icloud.com>
    @fracsinus @ronag
    fracsinus and ronag committed Nov 22, 2021
    Copy the full SHA
    8fdb45b View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. fs: add test for zero-length read 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @fracsinus @aduh95
    fracsinus and aduh95 committed Nov 23, 2021
    Copy the full SHA
    3d49687 View commit details
    Browse the repository at this point in the history