New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v16.13.1 proposal #40974
v16.13.1 proposal #40974
Commits on Oct 26, 2021
Commits on Nov 4, 2021
-
build: update codeowners-validator to 0.6
PR-URL: #40307 Reviewed-By: Mary Marchini <oss@mmarchini.me>
-
tools: update lint-md dependencies
Update lint-md dependencies and re-create lint-md.mjs. PR-URL: #40404 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
-
meta: consolidate AUTHORS entries for evantorrie
Add a .mailmap entry for evantorrie to consolidate their two AUTHORS entries into one. PR-URL: #40430 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
-
doc: indicate n-api out params that may be NULL
This is useful information to have for applications that don't need to read the other properties. The implementation checks for `nullptr`, see: https://github.com/nodejs/node/blob/master/src/js_native_api_v8.cc#L2879 PR-URL: #40371 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
meta: add
typings
to label-pr-configPR-URL: #40401 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
-
doc: update Collaborator guide to reflect GitHub web UI update
PR-URL: #40456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
-
meta: consolidate AUTHORS entries for ebickle
PR-URL: #40447 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-
src: ensure V8 initialized before marking milestone
PR-URL: #40405 Refs: electron/electron#31349 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
-
build: avoid run find inactive authors on forked repo
PR-URL: #40465 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
-
src: get embedder options on-demand
Only query embedder options when they are needed so that the bootstrap remains as stateless as possible so that the bootstrap snapshot is controlled solely by configure options, and subsequent runtime changes should be done in pre-execution. PR-URL: #40357 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
-
tools: update tools/lint-md dependencies to support GFM footnotes
PR-URL: #40445 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-
benchmark: increase crypto DSA keygen params
OpenSSL 3.0 increased the minimum values for these parameters. PR-URL: #40416 Fixes: #40410 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
-
meta: consolidate AUTHORS entries for emanuelbuholzer
PR-URL: #40469 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
-
PR-URL: #40485 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-
build: fix actions pull request's branch
PR-URL: #40494 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
-
-
src: add missing inialization in agent.h
This missing initialization was reported by the coverity scans we are in the process of re-enabling. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40379 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
-
Split test-crypto-dh.js so that it is less likely to timeout on less powerful bots. PR-URL: #40451 Refs: nodejs/reliability#86 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
-
-
Coverity scan reported a free after use and I think its right. Tweak to avoid double free. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40380 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
-
test: fix test-datetime-change-notify after daylight change
Add standard timezone name for Dublin without daylight saving PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
test,tools: increase timeout for benchmark tests
test-benchmark-buffer is consistently timing out on a single Windows host in CI. Rather than try to figure out if we need to scale the timeout up for a certain memory limit or chip speed or something else, let's increase the timeout for benchmark tests in general. PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
test,tools: increase pummel/benchmark test timeout from 4x to 6x
The win10-COMPILED_BY-vs2019 hosts in CI are very slow and timing out on certain tests in pummel and (previously) benchmark. Increase timeout from 4x to 6x. PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
-
-
-
tools: add support for import assertions in linter
PR-URL: #39924 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
-
lib,url: correct URL's argument to pass idlharness
`url.idl` defines URL's constructor as: ``` constructor(USVString url, optional USVString base); ``` `idlharness.any.js` checks its length as `1`. So we should remove constructor's second argument and use `arguments[1]` in constructor's logic. Refs: https://url.spec.whatwg.org/#idl-index PR-URL: #39848 Backport-PR-URL: #40383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
-
Commits on Nov 23, 2021
-
-
-
meta: consolidate AUTHORS entries for cxreg
PR-URL: #40490 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
-
The request uses chunked transfer encoding and the HTTP response status code is not 400 but 200. PR-URL: #40486 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
-
meta: consolidate AUTHORS entries for dguo
PR-URL: #40517 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-
meta: add Richard Lau to TSC list in README.md
Refs: nodejs/TSC#1096 PR-URL: #40523 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-
doc: add updating expected assets to release guide
Add a section to the Major Releases section of the release guide to cover updating the list of expected files for the promotion tool. PR-URL: #40470 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
-
src,fs: remove
ToLocalChecked()
call fromfs::AfterMkdirp()
This merges the `IsEmpty()` call and the `ToLocalChecked()` call into a single `ToLocal()` call. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40386 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
-
src,crypto: remove
AllocatedBuffer
fromcrypto_cipher.cc
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40400 Reviewed-By: Anna Henningsen <anna@addaleax.net>
-
typings: separate
internalBinding
typingsPR-URL: #40409 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
-
src,stream: remove
*Check*()
calls from non-Initialize()
functionsThere is no need to crash the process if any of these checks fail. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40425 Reviewed-By: Anna Henningsen <anna@addaleax.net>
-
doc: clarify behavior of napi_extended_error_info
Fix up example and make it more explicit on how you need to use napi_extended_error_info in order to help people avoid what might be a common mistake that we made in node-addon-api. Refs: nodejs/node-addon-api#1089 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40458 Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
-
-
meta: move one or more collaborators to emeritus
PR-URL: #40464 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com>
-
doc: update link in onboarding doc
PR-URL: #40539 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Nov 24, 2021
-
Refs: v8/v8@9.4.146.19...9.4.146.24 PR-URL: #40616 Refs: v8/v8@9.4.146.19...9.4.146.23 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
-
-
deps: add riscv64 config into openssl gypi
PR-URL: #40473 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
-
doc: document considerations for inclusion in core
Document the things that are considered when making the determination as to whether something should or shouldn't be in core. This does not (yet, at least) attempt to address *how* to include modules in core. (Should it be in the Node.js code base or vendored in from a separate repository?) It is limited to *whether* something should be in core or not. Closes: nodejs/TSC#1041 PR-URL: #40338 Fixes: nodejs/TSC#1041 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
-
-
meta: consolidate AUTHORS entries for dfabulich
PR-URL: #40527 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
-
doc: fix entry for Slack channel in onboarding.md
PR-URL: #40563 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
PR-URL: #40520 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
-
doc: use GFM footnotes in maintaining-V8.md (#40476)
PR-URL: #40476 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-
deps: V8: cherry-pick 422dc378a1da
Original commit message: [deserialization] Remove unnecessarily limit on buffer size 1. Now there is no serializer/deserializer-specific buffer size limit. 2. Update AUTHORS Ref: #40059 Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77084} Refs: v8/v8@422dc37 PR-URL: #40450 Fixes: #40059 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
-
-
-
tty: support more CI services in
getColorDepth
PR-URL: #40385 Refs: sindresorhus/yoctocolors#5 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
-
build: disable v8 pointer compression on 32bit archs
PR-URL: #40418 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
-
tools: udpate doc tools to accommodate GFM footnotes
PR-URL: #40477 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
-
doc: use GFM footnotes in webcrypto.md
PR-URL: #40477 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
-
PR-URL: #40554 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
-
PR-URL: #40580 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
-
doc: improve async_context introduction
- Rename "Async_context" to "Asynchronous context tracking" in toc. - Use named imports to show how `AsyncLocalStorage` and `AsyncResource` can be imported. PR-URL: #40560 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
-
-
doc: simplify ccache instructions
`ccache` has reasonable defaults for `max_size` and `cache_dir` so remove instructions to set those things explicitly. Change fenced code from `console` to `bash` for easier copy/paste. PR-URL: #40550 Fixes: #40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-
meta: consolidate AUTHORS entries for darai0512
PR-URL: #40569 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
Make starting Jenkins CI optional. PR-URL: #40570 Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
build: skip long-running Actions for README-only modifications
If the only file modified is README.md do not run test-linux or build-windows tasks. This will help streamline onboarding sessions but may help some other cases too. PR-URL: #40571 Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
policy: fix message for invalid manifest specifier
Add test for invalid manifest specifier and fix the error message which is missing a space ("singletrailing" instead of "single trailing"). PR-URL: #40574 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
-
Fix typo in v12.22.7, v14.18.1, and v16.11.1 changelogs. PR-URL: #40585 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Commits on Nov 25, 2021
-
meta: consolidate AUTHORS entries for clakech
PR-URL: #40589 Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
-
meta: move Fishrock123 to emeritus
I've moved on. I do not wish to be responsible for anything here and have been inactive for more than a year. PR-URL: #40596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
-
doc: add info on project's usage of coverity
Document project's used of coverity and how collaborators can get access. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40506 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
-
tools: fix formatting of warning message in update-authors.js
The email already has `<` and `>` surrounding it so adding it results in a misformatted message. PR-URL: #40600 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-
PR-URL: #40582 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
-
PR-URL: #40573 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
PR-URL: #40573 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
PR-URL: #40573 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
doc: use 'GitHub Actions workflow' instead
PR-URL: #40586 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
-
typings: improve internal bindings typings
PR-URL: #40411 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
meta: consolidate AUTHORS entries for Azard
PR-URL: #40619 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
meta: consolidate AUTHORS entries for alexzherdev
PR-URL: #40620 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
test: use conventional argument order in assertion
PR-URL: #40591 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
-
src: fix #endif description in crypto_keygen.h
PR-URL: #40639 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
doc: fix markdown syntax and HTML tag misses
PR-URL: #40608 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
doc: update tracking issues of startup performance
The issues listed in the doc have been closed, and a new one is currently being used to track snapshot integration. PR-URL: #40629 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
-
meta: consolidate AUTHORS entries for brettkiefer
PR-URL: #40599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
-
test: test
crypto.setEngine()
using an actual engineSigned-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40481 Reviewed-By: James M Snell <jasnell@gmail.com>
-
src: remove usage of
AllocatedBuffer
fromnode_http2
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
-
tools: avoid fetch extra commits when validating commit messages
PR-URL: #39128 Reviewed-By: Mary Marchini <oss@mmarchini.me>
-
typings: add JSDoc typings for inspector
Added JSDoc typings for the `inspector` lib module. PR-URL: #38390 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
-
doc: remove
--experimental-modules
documentationPR-URL: #38974 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
typings: add more bindings typings
PR-URL: #40415 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
-
tools,meta: remove exclusions from AUTHORS
The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: #232 (diff) Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions. PR-URL: #40648 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
-
tools: fix commit-lint workflow
PR-URL: #40673 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
-
tools: abort CQ session when landing several commits
Most PRs are meant to be squashed in one commit when landing. If the collaborator hasn't been using `fixup!` commits, the CQ lands the PR as several commits. This change makes the CQ abort by default when attempting to land several commits, unless there's another label added to the PR to force squashing or landing as several commits. Fixes: #40436 Refs: nodejs/node-core-utils#572 PR-URL: #40577 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
-
test,doc: correct documentation for runBenchmark()
The function only takes two arguments. PR-URL: #40683 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-
PR-URL: #40668 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-
tools: add script to update c-ares
Add a script to automate updating of the c-ares dependency and accompanying maintenance guide. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
-
Updated as described in doc/guides/maintaining-c-ares.md. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
-
PR-URL: #40643 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
doc: update cjs-module-lexer repo link
PR-URL: #40707 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
-
-
-
test: add semicolon after chunk size
The ABNF for chunk extensions as per RFC 7230 is chunk-ext = *( ";" chunk-ext-name [ "=" chunk-ext-val ] ) chunk-ext-name = token chunk-ext-val = token / quoted-string Add a semicolon after the chunk size for clarity. This does not invalidate the test as it verifies that the HTTP parser does not ignore chunk extensions. PR-URL: #40487 Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling Reviewed-By: James M Snell <jasnell@gmail.com>
-
tools: use GitHub Squash and Merge feature when using CQ
PR-URL: #40666 Refs: https://docs.github.com/en/rest/reference/pulls#merge-a-pull-request Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com>
-
PR-URL: #40734 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
-
• Removed unreachable code of the `evalModule()` function as an early error is thrown when the `print` parameter is a truthy value. • Make use of the nullish coalescing operator. PR-URL: #40664 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
-
tools: ensure the PR was not pushed before merging
When using Squash and Merge feature, it would allow to a malicious actor to push unreviewed code to their PR while the CQ is running and bypass the usual checks. This commit adds a check to refuse to land if the head of the PR branch is different from the one validated by ncu. PR-URL: #40747 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
tools: simplify and fix commit queue
Use `gh` CLI for CI and commit queue jobs, and use the correct token to merge PRs. PR-URL: #40742 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
-
src: make LoadEnvironment with string work with builtin modules path
-
-
meta: use form schema for flaky test template
PR-URL: #40737 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com>
Commits on Nov 29, 2021
Commits on Dec 1, 2021
-
2021-12-01, Version 16.13.1 'Gallium' (LTS)
Notable changes: - **deps**: upgrade npm to 8.1.2 (npm team) [#40643](#40643) - **deps**: update c-ares to 1.18.1 (Richard Lau) [#40660](#40660) - **doc**: add VoltrexMaster to collaborators (voltrexmaster) [#40566](#40566) - **lib**: fix regular expression to detect \`/\` and \`\\\` (Francesco Trotta) [#40325](#40325) PR-URL: #40974